Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoS Transaction Register Prune #563

Merged
merged 18 commits into from
Jul 20, 2023
Merged

PoS Transaction Register Prune #563

merged 18 commits into from
Jul 20, 2023

Conversation

AeonSw4n
Copy link
Contributor

No description provided.

@AeonSw4n AeonSw4n requested a review from a team as a code owner June 21, 2023 05:15
This was referenced Jun 21, 2023
Merged
Merged
@AeonSw4n
Copy link
Contributor Author

AeonSw4n commented Jun 21, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@AeonSw4n AeonSw4n changed the title Revert "Remove DeSoMempoolPoS" PoS Mempool Main Data Structure Jun 21, 2023
@AeonSw4n AeonSw4n force-pushed the p/pos-mempool-main-data-structure branch 2 times, most recently from a8843bd to 4dad2ee Compare July 5, 2023 22:43
Base automatically changed from p/pos-mempool-fee-time-buckets to feature/pos-mempool July 5, 2023 23:46
@AeonSw4n AeonSw4n force-pushed the p/pos-mempool-main-data-structure branch from 4dad2ee to 397dfe1 Compare July 6, 2023 01:12
@AeonSw4n AeonSw4n mentioned this pull request Jul 6, 2023
Merged
@AeonSw4n AeonSw4n force-pushed the p/pos-mempool-main-data-structure branch from 22017ca to 120e650 Compare July 13, 2023 02:55
This was referenced Jul 14, 2023
Merged
Merged
Merged
Merged
Merged
@AeonSw4n AeonSw4n changed the title PoS Mempool Main Data Structure PoS Transaction Register Prune Jul 14, 2023
tholonious
tholonious requested changes Jul 14, 2023
View reviewed changes
lib/pos_transaction_register.go Outdated Show resolved Hide resolved
lib/pos_transaction_register.go Outdated Show resolved Hide resolved
lib/pos_transaction_register.go Show resolved Hide resolved
lib/pos_transaction_register.go Show resolved Hide resolved
lib/pos_transaction_register.go Show resolved Hide resolved
lib/pos_transaction_register.go Outdated Show resolved Hide resolved
tholonious
tholonious requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@tholonious tholonious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor comments to simplify the logic for the new reverse iteration nested loop. We're good to merge after that.

lib/pos_transaction_register.go Outdated Show resolved Hide resolved
lib/pos_transaction_register.go Outdated Show resolved Hide resolved
lib/pos_transaction_register.go Outdated Show resolved Hide resolved
lib/pos_transaction_register.go Show resolved Hide resolved
lazynina
lazynina reviewed Jul 18, 2023
View reviewed changes
lib/pos_transaction_register.go Show resolved Hide resolved
lib/pos_transaction_register.go Show resolved Hide resolved
lib/pos_transaction_register.go Show resolved Hide resolved
lib/pos_transaction_register_test.go Outdated Show resolved Hide resolved
@deso-protocol deso-protocol deleted a comment from lazynina Jul 19, 2023
@AeonSw4n AeonSw4n merged commit 354f49e into feature/pos-mempool Jul 20, 2023
2 checks passed
@AeonSw4n AeonSw4n deleted the p/pos-mempool-main-data-structure branch July 20, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazynina lazynina lazynina approved these changes

@tholonious tholonious tholonious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AeonSw4n @lazynina @tholonious