Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Apache HttpClient with JDK 11 HttpClient #13

Closed
devatherock opened this issue Oct 19, 2020 · 1 comment
Closed

Replace Apache HttpClient with JDK 11 HttpClient #13

devatherock opened this issue Oct 19, 2020 · 1 comment
Labels
technical debt

Comments

@devatherock
Copy link
Owner

The Apache HttpClient was added to get around SSL errors when calling shields.io with micronaut's HttpClient. Replacing it with JDK 11's HttpClient would have the project depend only on micronaut apart from the JDK, thereby resulting in a hopefully simpler native image creation. The change needs to be tested to make sure the SSL errors don't come back
@devatherock
Copy link
Owner Author

Turned out the SSL errors were due to a JDK 11.0.1 bug. The upgrade to 11.0.8 in ab1cb2c fixed it, so we can just remove Apache HttpClient - no need to replace it with JDK HttpClient

@devatherock devatherock mentioned this issue Oct 26, 2020
Merged
devatherock added a commit that referenced this issue Oct 26, 2020
@devatherock
Merge pull request #22 from devatherock/13-remove-http-client
329f4f8 
Closes #13 and #19
devatherock added a commit that referenced this issue Nov 14, 2020
@devatherock
Closes #13 and #19
efbc339 
## Changes:
### Added
- #19: A
`BlockingHttpClient` bean

### Removed
- #13: Apache
HTTP Client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devatherock