fix: Fixed badge generation timeout

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 ### Changed
 - [#163](https://github.com/devatherock/artifactory-badge/issues/163): Used distroless base docker image
+- [#169](https://github.com/devatherock/artifactory-badge/issues/169): Fixed badge generation timeout due to missing reflection config for `io.netty.handler.ssl.SslHandler`
 
 ## [1.1.0] - 2022-05-12
 ### Added

Makefile

@@ -3,8 +3,12 @@ DOCKER_TAG=latest
 clean:
 	./gradlew clean
 integration-test:
-	docker-compose up > /dev/null &
-	./gradlew integrationTest
+	docker-compose up &
+	./gradlew integrationTest --tests '*ControllerIntegrationSpec*'
+	docker-compose down
+remote-integration-test:
+	docker-compose -f docker-compose-remote.yml up &
+	./gradlew integrationTest --tests '*RemoteUrlsIntegrationSpec*'
 	docker-compose down
 docker-build:
 	./gradlew clean build -Dgraalvm=true

docker-compose-remote.yml

@@ -0,0 +1,12 @@
+version: '2'
+services:
+
+  artifactory-badge:
+    image: devatherock/artifactory-badge:latest
+    network_mode: "host"
+    environment:
+      - ARTIFACTORY_URL=http://localhost:8081
+      - ARTIFACTORY_API_KEY=dummyKey
+      - LOGBACK_CONFIGURATION_FILE=https://raw.githubusercontent.com/devatherock/artifactory-badge/master/src/main/resources/logback-json.xml
+    ports:
+      - "8080:8080"

docker-compose.yml

@@ -8,6 +8,6 @@ services:
       - ARTIFACTORY_URL=http://localhost:8081
       - ARTIFACTORY_API_KEY=dummyKey
       - ARTIFACTORY_BADGE_SHIELDS_IO_URL=http://localhost:8081
-      - LOGBACK_CONFIGURATION_FILE=https://raw.githubusercontent.com/devatherock/artifactory-badge/master/src/main/resources/logback-json.xml
+      - LOGBACK_CONFIGURATION_FILE=logback-json.xml
     ports:
       - "8080:8080"

src/integrationTest/groovy/io/github/devatherock/artifactory/controllers/RemoteUrlsIntegrationSpec.groovy

@@ -0,0 +1,10 @@
+package io.github.devatherock.artifactory.controllers
+
+import io.micronaut.test.extensions.spock.annotation.MicronautTest
+
+/**
+ * Integration test that calls remote endpoints
+ */
+@MicronautTest(propertySources = 'classpath:application-integration.yml', startApplication = false)
+class RemoteUrlsIntegrationSpec extends RemoteUrlsSpec {
+}

src/test/groovy/io/github/devatherock/artifactory/controllers/DockerControllerTestSpec.groovy

@@ -5,6 +5,6 @@ import io.micronaut.test.extensions.spock.annotation.MicronautTest
 /**
  * Unit test for {@link DockerController}
  */
-@MicronautTest(startApplication = true)
+@MicronautTest
 class DockerControllerTestSpec extends DockerControllerSpec {
 }

src/test/groovy/io/github/devatherock/artifactory/controllers/RemoteUrlsSpec.groovy

@@ -0,0 +1,65 @@
+package io.github.devatherock.artifactory.controllers
+
+import static com.github.tomakehurst.wiremock.client.WireMock.equalTo
+import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo
+
+import javax.inject.Inject
+
+import io.github.devatherock.artifactory.service.DockerBadgeService
+import io.github.devatherock.test.TestUtil
+
+import com.github.tomakehurst.wiremock.WireMockServer
+import com.github.tomakehurst.wiremock.client.WireMock
+import io.micronaut.http.HttpRequest
+import io.micronaut.http.client.HttpClient
+import io.micronaut.http.client.annotation.Client
+import io.micronaut.http.uri.UriBuilder
+import spock.lang.Shared
+import spock.lang.Specification
+
+/**
+ * Test that calls remote endpoints. Needed for proper netty SSL reflection config
+ */
+abstract class RemoteUrlsSpec extends Specification {
+
+    @Shared
+    WireMockServer mockServer = new WireMockServer(8081)
+
+    @Inject
+    @Client('${test.server.url}')
+    HttpClient httpClient
+
+    void setupSpec() {
+        WireMock.configureFor(8081)
+        mockServer.start()
+    }
+
+    void cleanupSpec() {
+        mockServer.stop()
+    }
+
+    void cleanup() {
+        mockServer.resetAll()
+    }
+
+    void 'test get image size'() {
+        given:
+        String packageName = 'docker/devatherock/simple-slack'
+
+        and:
+        WireMock.givenThat(WireMock.get("/artifactory/${packageName}/latest/manifest.json")
+                .willReturn(WireMock.okJson(TestUtil.getManifest())))
+
+        when:
+        String badge = httpClient.toBlocking().retrieve(
+                HttpRequest.GET(UriBuilder.of('/docker/image-size')
+                        .queryParam('package', packageName).build()))
+
+        then:
+        WireMock.verify(1,
+                WireMock.getRequestedFor(urlEqualTo("/artifactory/${packageName}/latest/manifest.json"))
+                        .withHeader(DockerBadgeService.HDR_API_KEY, equalTo('dummyKey')))
+        badge.startsWith('<svg')
+        badge.endsWith('</svg>')
+    }
+}

src/test/groovy/io/github/devatherock/artifactory/controllers/RemoteUrlsTestSpec.groovy

@@ -0,0 +1,10 @@
+package io.github.devatherock.artifactory.controllers
+
+import io.micronaut.test.extensions.spock.annotation.MicronautTest
+
+/**
+ * Unit test that calls remote endpoints
+ */
+@MicronautTest(propertySources = ['classpath:application-test.yml', 'classpath:application-remote.yml'])
+class RemoteUrlsTestSpec extends RemoteUrlsSpec {
+}

src/test/groovy/io/github/devatherock/artifactory/controllers/VersionControllerTestSpec.groovy

@@ -5,6 +5,6 @@ import io.micronaut.test.extensions.spock.annotation.MicronautTest
 /**
  * Unit test for {@link VersionController}
  */
-@MicronautTest(startApplication = true)
+@MicronautTest
 class VersionControllerTestSpec extends VersionControllerSpec {
 }

src/test/resources/application-remote.yml

@@ -0,0 +1,4 @@
+artifactory:
+  badge:
+    shields-io:
+      url: https://img.shields.io