Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve trailing newline in mangle.json #497

Closed
developit opened this issue Oct 18, 2019 · 1 comment · Fixed by #882 or #900
Closed

Preserve trailing newline in mangle.json #497

developit opened this issue Oct 18, 2019 · 1 comment · Fixed by #882 or #900
Labels
enhancement 🚀 good first issue hacktoberfest-accepted Hacktoberfest

Comments

@developit
Copy link
Owner

developit commented Oct 18, 2019 •
edited
Loading

Currently, mangle.json writes always remove a trailing newline from the file. We could detect the existence of the trailing newline when reading, then preserve whatever was used when writing.

See https://github.com/preactjs/preact/blob/e22cc99ca398bb0a417ccc151a520c41215afe55/.editorconfig#L17-L22
@brynmrk brynmrk mentioned this issue Oct 19, 2019
Closed
@mclizz
Copy link

mclizz commented Dec 1, 2019

<!doctype html>

<script defer> // modernBuild = Modules + Dynamic Import support import('./dist/test.js'); window.modernBuild = true; </script> <script defer> if (!window.modernBuild) { document.head.appendChild(Object.assign(document.createElement('script'), { src: './jspm_packages/npm/systemjs@5.0.0/dist/s.min.js', onload: function () { System.import('./dist-system/test.js'); } })); } </script>

make-github-pseudonymous-again added a commit to make-github-pseudonymous-again/set-alarm that referenced this issue Mar 6, 2021
@make-github-pseudonymous-again
🔧 config(mangle): Remove EOF newline in config file.
ab177d6 
Otherwise the `build` script modifies tracked files.

See developit/microbundle#497.
mikr13 added a commit to mikr13/microbundle that referenced this issue Aug 22, 2021
@mikr13
feat: ✨ Closes developit#497: preserve trailing newline in mangle.json
31f7a7d 
this commit adds editorconfig & index.js changes to enable trailing new line detection & addition in mangle.json

*
@mikr13 mikr13 mentioned this issue Aug 22, 2021
Merged
ForsakenHarmony added a commit that referenced this issue Oct 14, 2021
@mikr13 @ForsakenHarmony
feat: ✨ Closes #497: preserve trailing newline in mangle.json (#882)
2a0ca88 
Co-authored-by: Leah <github.leah@hrmny.sh>
@preact-bot preact-bot mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🚀 good first issue hacktoberfest-accepted Hacktoberfest
Projects
None yet
Milestone
No milestone
3 participants
@developit @ForsakenHarmony @mclizz