Added editorconfig properties for preserving trailing newline #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brynmrk! Thanks for the PR! This is what we'll want to add to repositories that are built with Microbundle, but I think in order to fix #497 there may be one additional thing required: we need to check for the extra trailing line ending when reading in the Think you'd be interested in add that to your PR? Cheers! |
developit
reviewed
Oct 21, 2019
| @@ -22,8 +22,8 @@ Build \\"aliasMapping\\" to dist: | |||
| 46 B: alias-mapping.js.br | |||
| 62 B: alias-mapping.esm.js.gz | |||
| 46 B: alias-mapping.esm.js.br | |||
| 118 B: alias-mapping.umd.js.gz | |||
There was a problem hiding this comment.
I've updated the tests now that #495 is merged, so only two should be failing. We can actually skip updating the snapshots for that in this PR since it's a real bug still to be fixed elsewhere :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497