Skip to content

fix: Ensure loadTexture returns Texture, not TextureProps #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 2 commits into from
Dec 28, 2025
Merged

fix: Ensure loadTexture returns Texture, not TextureProps #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b89e21
feat: Pass `device` to `loadTexture` in COGLayer
kylebarron Dec 28, 2025
0f7c57c
Ensure loadTexture returns Texture, not TextureProps
kylebarron Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/deck.gl-geotiff/src/cog-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type {
} from "@developmentseed/deck.gl-raster";
import { RasterLayer, RasterTileset2D } from "@developmentseed/deck.gl-raster";
import type { ReprojectionFns } from "@developmentseed/raster-reproject";
import type { TextureProps } from "@luma.gl/core";
import type { Device, Texture } from "@luma.gl/core";
import type { GeoTIFF, GeoTIFFImage, Pool } from "geotiff";
import proj4 from "proj4";
import { parseCOGTileMatrixSet } from "./cog-tile-matrix-set.js";
Expand Down Expand Up @@ -62,18 +62,19 @@ export interface COGLayerProps extends CompositeLayerProps {
* The default implementation loads an RGBA image using geotiff.js's readRGB
* method, returning an ImageData object.
*
* For more customizability, you can also return a TextureProps object from
* For more customizability, you can also return a Texture object from
* luma.gl, along with optional custom shaders for the RasterLayer.
*/
loadTexture?: (
image: GeoTIFFImage,
options: {
device: Device;
window: [number, number, number, number];
signal?: AbortSignal;
pool: Pool;
},
) => Promise<{
texture: ImageData | TextureProps;
texture: ImageData | Texture;
shaders?: RasterLayerProps["shaders"];
height: number;
width: number;
Expand Down Expand Up @@ -184,7 +185,7 @@ export class COGLayer extends CompositeLayer<COGLayerProps> {
getTileData: async (
tile,
): Promise<{
texture: ImageData | TextureProps;
texture: ImageData | Texture;
shaders?: RasterLayerProps["shaders"];
height: number;
width: number;
Expand Down Expand Up @@ -215,6 +216,7 @@ export class COGLayer extends CompositeLayer<COGLayerProps> {

const { texture, height, width, shaders } = await this.props
.loadTexture!(geotiffImage, {
device: this.context.device,
window,
signal,
pool: this.props.pool || defaultPool(),
Expand Down Expand Up @@ -243,7 +245,7 @@ export class COGLayer extends CompositeLayer<COGLayerProps> {
pixelToInputCRS,
inputCRSToPixel,
}: {
texture: ImageData | TextureProps;
texture: ImageData | Texture;
shaders?: RasterLayerProps["shaders"];
height: number;
width: number;
Expand Down