Skip to content

Commit

Permalink
VolumeMount should require Volume component definition (#101)
Browse files Browse the repository at this point in the history 
* VolumeMount should require Volume component definition

* update generated schemas
  • Loading branch information
@kadel
kadel authored Jul 21, 2020
1 parent 2b9600b commit 9e58fa5
Show file tree
Hide file tree
Showing 7 changed files with 64 additions and 77 deletions.
40 changes: 17 additions & 23 deletions deploy/crds/workspace.devfile.io_devworkspaces_crd.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -530,11 +530,10 @@ spec:
properties:
name:
description: The volume mount name is the name of
an existing `Volume` component. If no corresponding
`Volume` component exist it is implicitly added.
If several containers mount the same volume name
then they will reuse the same volume and will
be able to access to the same files.
an existing `Volume` component. If several containers
mount the same volume name then they will reuse
the same volume and will be able to access to
the same files.
type: string
path:
description: The path in the component container
Expand Down Expand Up @@ -1275,12 +1274,10 @@ spec:
name:
description: The volume mount name is
the name of an existing `Volume` component.
If no corresponding `Volume` component
exist it is implicitly added. If several
containers mount the same volume name
then they will reuse the same volume
and will be able to access to the same
files.
If several containers mount the same
volume name then they will reuse the
same volume and will be able to access
to the same files.
type: string
path:
description: The path in the component
Expand Down Expand Up @@ -2096,12 +2093,10 @@ spec:
properties:
name:
description: The volume mount name is the name
of an existing `Volume` component. If no corresponding
`Volume` component exist it is implicitly
added. If several containers mount the same
volume name then they will reuse the same
volume and will be able to access to the same
files.
of an existing `Volume` component. If several
containers mount the same volume name then
they will reuse the same volume and will be
able to access to the same files.
type: string
path:
description: The path in the component container
Expand Down Expand Up @@ -2862,12 +2857,11 @@ spec:
name:
description: The volume mount name
is the name of an existing `Volume`
component. If no corresponding `Volume`
component exist it is implicitly
added. If several containers mount
the same volume name then they will
reuse the same volume and will be
able to access to the same files.
component. If several containers
mount the same volume name then
they will reuse the same volume
and will be able to access to the
same files.
type: string
path:
description: The path in the component
Expand Down
36 changes: 15 additions & 21 deletions deploy/crds/workspace.devfile.io_devworkspacetemplates_crd.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -497,11 +497,10 @@ spec:
properties:
name:
description: The volume mount name is the name of an
existing `Volume` component. If no corresponding `Volume`
component exist it is implicitly added. If several
containers mount the same volume name then they will
reuse the same volume and will be able to access to
the same files.
existing `Volume` component. If several containers
mount the same volume name then they will reuse the
same volume and will be able to access to the same
files.
type: string
path:
description: The path in the component container where
Expand Down Expand Up @@ -1224,11 +1223,9 @@ spec:
name:
description: The volume mount name is the
name of an existing `Volume` component.
If no corresponding `Volume` component exist
it is implicitly added. If several containers
mount the same volume name then they will
reuse the same volume and will be able to
access to the same files.
If several containers mount the same volume
name then they will reuse the same volume
and will be able to access to the same files.
type: string
path:
description: The path in the component container
Expand Down Expand Up @@ -2008,11 +2005,10 @@ spec:
properties:
name:
description: The volume mount name is the name of
an existing `Volume` component. If no corresponding
`Volume` component exist it is implicitly added.
If several containers mount the same volume name
then they will reuse the same volume and will
be able to access to the same files.
an existing `Volume` component. If several containers
mount the same volume name then they will reuse
the same volume and will be able to access to
the same files.
type: string
path:
description: The path in the component container
Expand Down Expand Up @@ -2753,12 +2749,10 @@ spec:
name:
description: The volume mount name is
the name of an existing `Volume` component.
If no corresponding `Volume` component
exist it is implicitly added. If several
containers mount the same volume name
then they will reuse the same volume
and will be able to access to the same
files.
If several containers mount the same
volume name then they will reuse the
same volume and will be able to access
to the same files.
type: string
path:
description: The path in the component
Expand Down
1 change: 0 additions & 1 deletion pkg/apis/workspaces/v1alpha1/containerComponent.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ type EnvVar struct {
// Volume that should be mounted to a component container
type VolumeMount struct {
// The volume mount name is the name of an existing `Volume` component.
// If no corresponding `Volume` component exist it is implicitly added.
// If several containers mount the same volume name
// then they will reuse the same volume and will be able to access to the same files.
Name string `json:"name"`
Expand Down
16 changes: 8 additions & 8 deletions schemas/devfile.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -532,9 +532,9 @@
"description": "Volume that should be mounted to a component container",
"properties": {
"name": {
"description": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"description": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"type": "string",
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
},
"path": {
"description": "The path in the component container where the volume should be mounted. If not path is mentioned, default path is the is `/<name>`.",
Expand Down Expand Up @@ -1271,9 +1271,9 @@
"description": "Volume that should be mounted to a component container",
"properties": {
"name": {
"description": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"description": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"type": "string",
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
},
"path": {
"description": "The path in the component container where the volume should be mounted. If not path is mentioned, default path is the is `/<name>`.",
Expand Down Expand Up @@ -2211,9 +2211,9 @@
"description": "Volume that should be mounted to a component container",
"properties": {
"name": {
"description": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"description": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"type": "string",
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
},
"path": {
"description": "The path in the component container where the volume should be mounted. If not path is mentioned, default path is the is `/<name>`.",
Expand Down Expand Up @@ -2949,9 +2949,9 @@
"description": "Volume that should be mounted to a component container",
"properties": {
"name": {
"description": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"description": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files.",
"type": "string",
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If no corresponding `Volume` component exist it is implicitly added. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
"markdownDescription": "The volume mount name is the name of an existing `Volume` component. If several containers mount the same volume name then they will reuse the same volume and will be able to access to the same files."
},
"path": {
"description": "The path in the component container where the volume should be mounted. If not path is mentioned, default path is the is `/<name>`.",
Expand Down
Loading

0 comments on commit 9e58fa5

Please sign in to comment.