Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeMount should require Volume component definition #101

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

kadel
Copy link
Member

@kadel kadel commented Jul 20, 2020

What does this PR do?

VolumeMount should require Volume component definition.
Otherwise, it doesn't make much sense to add it implicitly.
One of the reasons is that could lead to errors like this:

components:
  - container:
      name: cont1
      volumeMounts:
        - name: myvolume
  - container:
      name: cont2
      volumeMounts:
        # I want to use myvolume, but made a typo
        - name: myvoluem

volumes:
   - name: myvolume

What issues does this PR fix or reference?

Is your PR tested? Consider putting some instruction how to test your changes

Docs PR

@maysunfaisal
Copy link
Member

maysunfaisal commented Jul 21, 2020

@l0rd @davidfestal when and how is the schema here updated? https://devfile.github.io/devfile/_attachments/api-reference.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants