Add Build Guidances #127
Closed
Add Build Guidances #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtam2018
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
* Make BuildGuidance a pointer * Update tests
wtam2018
changed the title
sleshchenko
reviewed
Sep 15, 2020
|
|
||
| // +optional | ||
| // Path of source directory to establish build context. Default to the top level directory. | ||
| BuildContext string `json:"buildContext,omitempty"` |
There was a problem hiding this comment.
I am not sure if we want to continue to work on this branch for Build Guidance or open a new PR but for record, I had a question:
What is the difference between this BuildContext and the one provided from the Console POC import from devfile form openshift/console#6321
|
@wtam2018: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
github-actions
bot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
BuildGuidanceswhich includesDockerfileandSourceToImagefor build strategies. It is added to top level so that they can be shared by multiple projects.What issues does this PR fix or reference?
#51
Is your PR tested? Consider putting some instruction how to test your changes
Not applicable.
Docs PR