(POC) Add devfile v2 outerloop flow to console #6321

reginapizza · 2020-08-12T19:36:04Z

This PR is to implement the Import from Devfile flow.

UX mocks for this flow can be found here

Changes made and what is left to do is documented here.

Full demo video can be found here.

@Shraddhak22 @jaideepr97 @ranakan19 @wtam2018 @mitchharpur

…form

openshift-ci-robot · 2020-08-12T19:36:26Z

Hi @reginapizza. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-08-12T19:53:10Z

Thanks for opening up this PR @reginapizza - I'll look through and see what you have come up with. Would you mind updating the description with a couple screenshots / gifs of the work you have done so it's clearer at a glance?

/hold
/assign

Also a little bookkeeping - Master is currently pointing at 4.6, and this is a 4.7 implementation. So just going to put a cautionary hold on this PR while we review the changes and discuss things.

reginapizza · 2020-08-12T20:55:38Z

@andrewballantyne PR description has been updated with screenshots!

My apologies about not understanding the versioning, still getting used to things here... should I update from master to relesease-4.7 then?

submit utils and mocking backend

…console into jd-addDevfile

Added backend to frontend communication

…vfileBackendCommunication

reginapizza · 2020-09-30T20:29:09Z

Just a quick update: things are working on the UI side for the most part, the last big puzzle piece to complete the flow is getting the devfile/parser library to work. The diagram below shows how the communication works between the app and the library; in place of the devfile/parser library we are using mocked data in the backend.

Please see this doc for a more in-depth status update, including items that are still on the to-do list.

serenamarie125

Please add the "Dev Preview" badge on the Import from devfile form page. Thanks!

openshift-ci-robot · 2020-10-20T03:41:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reginapizza
To complete the pull request process, please assign rhamilto after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhamilto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewballantyne · 2020-10-30T17:30:00Z

@reginapizza Are we going to want to get this in before the backend is ready. Based on the meeting yesterday it sounded like they are moving the right direction but are not yet ready. I think we may be able to get this into the UI and swing back with a go update to add the proper connectivity to the devfile lib.

Thoughts?

reginapizza · 2020-10-30T18:50:41Z

Please add the "Dev Preview" badge on the Import from devfile form page. Thanks!

@serenamarie125 The images in the original description were outdated, the badge is currently there though. I've updated the description to include a full demo video that accurately reflects the code here now.

serenamarie125 · 2020-11-08T02:11:27Z

@serenamarie125 The images in the original description were outdated, the badge is currently there though. I've updated the description to include a full demo video that accurately reflects the code here now.

Looks great, thanks @reginapizza

jaideepr97 · 2020-11-08T13:17:59Z

@reginapizza Are we going to want to get this in before the backend is ready. Based on the meeting yesterday it sounded like they are moving the right direction but are not yet ready. I think we may be able to get this into the UI and swing back with a go update to add the proper connectivity to the devfile lib.

Thoughts?

Sounds good to me @andrewballantyne

maysunfaisal · 2020-11-12T22:21:03Z

FYI, the devfile library PR is up for review at devfile/library#44

andrewballantyne · 2020-11-12T23:04:42Z

I'll look to take over this PR going into next sprint. Thanks @maysunfaisal !

maysunfaisal · 2020-11-16T19:38:19Z

frontend/packages/dev-console/src/components/import/git/GitSection.tsx

    if (validated === ValidatedOptions.warning) {
      return 'URL is valid but cannot be reached. If this is a private repository, enter a source secret in Advanced Git Options';
    }
+    if (validated === ValidatedOptions.warning) {
+      return 'Valid URL but devfile build guidance not available.';
+    }


Both these if conditions check for warning. Looks like the condition for not reachable should be an error looking at the logic above in this file

Interesting, I'll have to validate the UI code once I move it over. I'm trying to close off the ticket I'm working on but clusters seem to be having some issues today. Good catch though.

andrewballantyne · 2020-11-23T11:58:55Z

/close

See #7299 for the continued work on Devfile addition to DevConsole.

openshift-ci-robot · 2020-11-23T11:59:13Z

@andrewballantyne: Closed this PR.

In response to this:

/close

See #7299 for the continued work on Devfile addition to DevConsole.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

reginapizza added 2 commits August 12, 2020 13:18

added isDevfilePresent function and associated tests

9d760b8

added devfile import form and tile, incorporated isDevfilePresent to …

104badb

…form

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2020

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2020

openshift-ci-robot requested review from christoph-jerolimov and rottencandy August 12, 2020 19:36

openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service labels Aug 12, 2020

openshift-ci-robot assigned andrewballantyne Aug 12, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020

reginapizza and others added 16 commits August 21, 2020 13:25

removed devfile props from lazy loader

0a2224e

Removed validation for devfiles with dockerfileValidationSchema

9626a0a

Removed error from previous commit

cfd0be7

Added beginnings of communication with backend

8013d74

Added functions to detect if devfile is present & to get devfile content

761935d

Added parser to get devfile version and logic to use version

a08a584

start of new function to use devfile for building

bc01c23

rough code for createOrUpdateBuildResource

eb127b1

more guideline code

b4ebb85

pending test of mock data

260fd93

Merge pull request #10 from reginapizza/jd-addDevfile

b5eae9c

submit utils and mocking backend

removed promise return from devfileCreate

9bbfb1f

fixed errors with devfileFlow

f0478f9

Merge branch 'devfileBackendCommunication' of github.com:reginapizza/…

a1e5b33

…console into jd-addDevfile

solved merge conflicts from regina-devfile

4064c3d

mock build complete - need to revisit

5f70552

jaideepr97 and others added 10 commits September 28, 2020 16:12

fixed save button issue with mockdata frontend

428c35f

Merge pull request #17 from reginapizza/jd-odc-add-devfile

b986801

Added backend to frontend communication

added comments and code cleanup

3dc2606

fixed service/route not showing up issue

413ae83

merged from upstream

00ed4a3

api addition and commenting out mocked data

424d354

readding in jaideep's changes

f371d19

Merge branch 'master' of https://github.com/openshift/console into de…

930af0b

…vfileBackendCommunication

removed mocked data from frontend- using backend mocked only

feb1f20

small code cleanup

7054371

openshift-ci-robot added the component/backend Related to backend label Sep 30, 2020

reginapizza changed the title ~~(WIP) Add devfile v2 outerloop flow to console~~ (POC) Add devfile v2 outerloop flow to console Oct 7, 2020

serenamarie125 suggested changes Oct 20, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2020

maysunfaisal reviewed Nov 16, 2020

View reviewed changes

This was referenced Nov 16, 2020

Add Build Guidances devfile/api#127

Closed

Initial proposal for Console devfile feature w/o Build Guidance Spec devfile/api#219

Merged

andrewballantyne mentioned this pull request Nov 23, 2020

Devfile Add Flow #7299

Merged

4 tasks

openshift-ci-robot closed this Nov 23, 2020

reginapizza deleted the addDevfile branch April 21, 2022 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(POC) Add devfile v2 outerloop flow to console #6321

(POC) Add devfile v2 outerloop flow to console #6321

reginapizza commented Aug 12, 2020 •

edited

Loading

openshift-ci-robot commented Aug 12, 2020

andrewballantyne commented Aug 12, 2020

reginapizza commented Aug 12, 2020

reginapizza commented Sep 30, 2020

serenamarie125 left a comment

openshift-ci-robot commented Oct 20, 2020

andrewballantyne commented Oct 30, 2020

reginapizza commented Oct 30, 2020

serenamarie125 commented Nov 8, 2020

jaideepr97 commented Nov 8, 2020

maysunfaisal commented Nov 12, 2020

andrewballantyne commented Nov 12, 2020

maysunfaisal Nov 16, 2020

andrewballantyne Nov 16, 2020

andrewballantyne commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

(POC) Add devfile v2 outerloop flow to console #6321

(POC) Add devfile v2 outerloop flow to console #6321

Conversation

reginapizza commented Aug 12, 2020 • edited Loading

openshift-ci-robot commented Aug 12, 2020

andrewballantyne commented Aug 12, 2020

reginapizza commented Aug 12, 2020

reginapizza commented Sep 30, 2020

serenamarie125 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 20, 2020

andrewballantyne commented Oct 30, 2020

reginapizza commented Oct 30, 2020

serenamarie125 commented Nov 8, 2020

jaideepr97 commented Nov 8, 2020

maysunfaisal commented Nov 12, 2020

andrewballantyne commented Nov 12, 2020

maysunfaisal Nov 16, 2020

Choose a reason for hiding this comment

andrewballantyne Nov 16, 2020

Choose a reason for hiding this comment

andrewballantyne commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

reginapizza commented Aug 12, 2020 •

edited

Loading