Remove plugin registry #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Approved assuming that WTO related stuff will be restored in #252 or in further PR:
- default WTO container
- using WTO plugin by id (at least for time being until we did not find better way)
- RELATED_IMAGE_ stuff
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
As of PR devfile#23, plugins in the meta.yaml format are no longer supported. Going forward, only devfiles specifying plugins according to devfile 2.0 conventions should be handled by the controller. As a result, it no longer makes sense to maintain a devfile v1 plugin registry alongside the controller. This also removes the requirement to resolve the plugin registry URL at deploy time, simplifying the controller deploy process. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
With the move away from devfile v1 plugin meta.yamls, code related to adapting devfile v2 to devfile v1 is no longer relevant. This commit removes * The component controller and its setup (this controller is not compatible with devfile 2.0 structures and would require extensive, breaking changes to adapt) * The adaptor package, which is used to process dockerimage and plugin components (devfile v1). * Internal code for processing plugin meta.yamls Signed-off-by: Angel Misevski <amisevsk@redhat.com>
The internal plugin registry serves deprecated plugin meta.yaml files, which are compatible with devfile v1 only. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Kubectl/oc log to stderr if they fail to connect to a cluster, which results in the platform check logging The connection to the server xxxx was refused - did you specify the right host or port? on every invocation if not connected to a cluster. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com> Co-authored-by: Serhii Leshchenko <sleshche@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
remove-plugin-registry
branch
from
621a1ce to
1f83c92
Compare
|
I've rebased on master. To make rebasing #263 on top of this easier, I've undone some of the changes (remove meta.yamls from the internal registry and re-add some of the image-handling functions.) |
|
/test v5-devworkspaces-operator-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes old code related to devfile v1 and plugin meta.yamls:
Componentsis not helpful for what we need to do with DevWorkspaces.)pkg/adaptorsince that was used in the component controllerAlso has minor fixes for issues I encountered while cleaning up the code:
The connection to the server xxxx was refused - did you specify the right host or port?when not connected to a clusterThis PR leaves the Component CRD in place as we should figure out how to deprecate it in WTO.
What issues does this PR fix or reference?
Follow-up to #237, which removes components from the reconcile process and disables support for plugins. Plugins support is re-implemented in #240, without the use of components or related code.
Is it tested? How?
Tested on
minikubeandcrc.Additional Information
This PR also makes it easier to support cases like using
chectlto deploy this operator, as setting the plugin registry URL in the controller's configmap could be complicated to do at build time.