Enable referencing plugin components by ID (internal-registry only) #263
Conversation
amisevsk
changed the title
| command: ["/go/bin/che-machine-exec", | ||
| "--authenticated-user-id", "$(DEVWORKSPACE_CREATOR)", | ||
| "--idle-timeout", "$(DEVWORKSPACE_IDLE_TIMEOUT)", | ||
| "--pod-selector", "controller.devfile.io/workspace_id=$(CHE_WORKSPACE_ID)", |
There was a problem hiding this comment.
let's start using DEVWORKSPACE_ID here and in other place instead of Che related
| protocol: http | ||
| attributes: | ||
| type: ide | ||
| cookiesAuthEnabled: "true" |
There was a problem hiding this comment.
Is it still relevant? and after we introduce POST method there, it might be not safe.
So, I just propose to remove unused stuff for time being.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/test v5-devworkspaces-operator-e2e |
|
/retest |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Re-implement defaulting functionality for web terminal devworkspaces;
applies a default container component to the DevWorkspace if
a) it imports the web-terminal plugin, and
b) the DevWorkspace does not contain any container components
The default container can be configured via the property
devworkspace.default_dockerimage.redhat-developer.web-terminal
if left empty, a default container is provisioned.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
Forgot to push my locally-rebased branch on Friday :D |
|
/test v5-devworkspaces-operator-e2e |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
/retest |
|
/test v5-devworkspaces-operator-e2e |
|
The full WTO flow works with changes from eclipse-che/che-machine-exec#129 applied \o/ |
What does this PR do?
Implements the internal registry for components that specify a plugin by ID. This re-enables the normal web terminal flow (including defaulting the tooling container component)
What issues does this PR fix or reference?
Part of #249
Is it tested? How?
Note: opening the web terminal from the openshift UI will not work, due to #258