Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workspace SA to read pod metrics in current namespace #695

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

amisevsk
Copy link
Collaborator

@amisevsk amisevsk commented Dec 3, 2021

What does this PR do?

Adds permissions

- apiGroups:
  - metrics.k8s.io
  resources:
  - pods
  verbs:
  - get
  - list
  - watch

to the workspace ServiceAccount

What issues does this PR fix or reference?

Needed for eclipse-che/che#20800

Is it tested? How?

Create a DevWorkspace and verify workspace role is updated.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk amisevsk requested review from svor and JPinkney December 3, 2021 17:31
@openshift-ci openshift-ci bot added the approved label Dec 3, 2021
@amisevsk amisevsk changed the title Wksp metrics rbac Allow workspace SA to read pod metrics in current namespace Dec 3, 2021
@amisevsk
Copy link
Collaborator Author

amisevsk commented Dec 3, 2021

/test v8-devworkspace-operator-e2e

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk amisevsk merged commit fa695a6 into devfile:main Dec 6, 2021
@amisevsk amisevsk deleted the wksp-metrics-rbac branch December 6, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants