Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

fix(resource-monitor): get DW Namespace name from ENV variable #1269

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

svor
Copy link
Contributor

@svor svor commented Dec 7, 2021

Signed-off-by: svor vsvydenk@redhat.com

What does this PR do?

Reads namespace's name form the environment variable

depends on devworkspace-operator 0.12.0 devfile/devworkspace-operator#695

Screenshot/screencast of this PR

Screenshot from 2021-12-07 14-48-03

What issues does this PR fix or reference?

eclipse-che/che#20800

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: svor <vsvydenk@redhat.com>
@svor svor self-assigned this Dec 7, 2021
@svor svor requested a review from vitaliy-guliy as a code owner December 7, 2021 13:21
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1269 (1c70a12) into main (c299f59) will increase coverage by 3.02%.
The diff coverage is 28.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
+ Coverage   32.78%   35.81%   +3.02%     
==========================================
  Files         290      324      +34     
  Lines        9885    10480     +595     
  Branches     1457     1356     -101     
==========================================
+ Hits         3241     3753     +512     
- Misses       6641     6723      +82     
- Partials        3        4       +1     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...se-che-theia-plugin-ext/src/common/che-protocol.ts 100.00% <ø> (ø)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad8e11...1c70a12. Read the comment docs.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as it's still better than what we have today

@che-bot
Copy link
Contributor

che-bot commented Dec 7, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1269
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1269

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Signed-off-by: svor <vsvydenk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Dec 7, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1269
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1269

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@svor
Copy link
Contributor Author

svor commented Dec 8, 2021

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 8, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1269
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1269

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@svor svor merged commit 68f1e4e into main Dec 8, 2021
@svor svor deleted the sv-fix-resourceMonitor branch December 8, 2021 10:43
@che-bot che-bot added this to the 7.41 milestone Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants