-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Draft] Allow DevWorkspaceID to be overridden via annotation #747
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ac3e37b
to
eeab3c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Works like a charm \o/
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I would propose 25 chars (current value of the ID, and the same length is used for che-server devfile v1 workspaces) |
Related issue for UD - eclipse-che/che#21153 |
/test v8-devworkspace-operator-e2e |
What does this PR do?
Allow overriding the default DevWorkspace ID (derived from the DevWorkspace CR's UUID) via the annotation
with the caveats:
.status.devworkspaceId
This PR is in draft status for testing if this feature is useful for migrating Che workspaces to the DevWorkspace controller.
Before merging, this PR needs a polishing pass. We should also decide on a max length for overridden workspace IDs, as the controller implicitly assumes the length of the ID is fixed in a few places (where workspace ID is used as part of a k8s object name, for example).
Changes can be tested using the image
quay.io/amisevsk/devworkspace-controller:override-dw-id
(for both controller and webhooks server)What issues does this PR fix or reference?
N/A for now.
Is it tested? How?
No changes if annotation is not used; otherwise, workspace ID should be set to value of annotation.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che