Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on recent betas of visionOS #371

Closed
wants to merge 2 commits into from

Conversation

chrisvasselli
Copy link
Contributor

@chrisvasselli chrisvasselli commented Oct 30, 2023

In recent visionOS betas, #if os(xrOS) is now #if os(visionOS), and #if os(iOS) no longer returns true on visionOS. This required some updates to DeviceKit.

This is not meant to be a PR to fully support Apple Vision Pro information, just something to get DeviceKit building properly on the latest visionOS betas, and provide some scaffolding to start filling out information as it becomes available.

Fixes #370

@BProg
Copy link

BProg commented Jan 11, 2024

Hi, any news on this?

@Zandor300
Copy link
Member

@chrisvasselli @BProg
I've made another PR, that doesn't exclude the entire library when compiling. I'm unable to reproduce the actual issue you are having so could you try my PR or provide an example project where it is happening?

#376

@chrisvasselli
Copy link
Contributor Author

Hi @Zandor300!

You can reproduce the issue by opening the DeviceKit workspace from this repo, and adding Vision Pro to the supported destinations. Then select the Vision Pro simulator as your run destination and attempt to build.

If you're still having trouble reproducing, please let me know!

CleanShot 2024-01-17 at 13 04 12@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer compiles on visionOS
3 participants