Fix building for visionOS. #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Source/Device.generated.swift # Source/Device.swift.gyb
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -628,6 +628,9 @@ public enum Device { | |||
| case "i386", "x86_64", "arm64": return simulator(mapToDevice(identifier: ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"] ?? "watchOS")) | |||
| default: return unknown(identifier) | |||
| } | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:632 |
| @@ -1162,6 +1161,9 @@ public enum Device { | |||
| return allTVs | |||
| #elseif os(watchOS) | |||
| return allWatches | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:1165 |
| @@ -1401,6 +1403,9 @@ public enum Device { | |||
| } | |||
| #elseif os(tvOS) | |||
| return nil | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:1407 |
| @@ -1554,6 +1559,9 @@ extension Device: CustomStringConvertible { | |||
| case .simulator(let model): return "Simulator (\(model.description))" | |||
| case .unknown(let identifier): return identifier | |||
| } | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:1563 |
| @@ -1687,6 +1695,9 @@ extension Device: CustomStringConvertible { | |||
| case .simulator(let model): return "Simulator (\(model.safeDescription))" | |||
| case .unknown(let identifier): return identifier | |||
| } | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:1699 |
| @@ -2326,6 +2337,9 @@ extension Device { | |||
| case .simulator(let model): return model.cpu | |||
| case .unknown: return .unknown | |||
| } | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:2341 |
| @@ -2377,6 +2391,9 @@ extension Device.CPU: CustomStringConvertible { | |||
| case .s9: return "S9" | |||
| case .unknown: return "unknown" | |||
| } | |||
| #elseif os(visionOS) | |||
| // TODO: Replace with proper implementation for visionOS. | |||
There was a problem hiding this comment.
TODOs should be resolved (Replace with proper implementa…).todo Device.generated.swift:2395 |
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
furiosFast
added a commit
to furiosFast/DeviceKit
that referenced
this pull request
May 31, 2024
* master: Version bump. (v5.4.0) Add unknown orientation variant (devicekit#411) Version bump. (v5.3.1) Fix path for PrivacyInfo.xcprivacy in test target. Process Privacy manifest instead of copy on SPM. (devicekit#409) Version bump. (v5.3.0) Support for new May 2024 devices. (devicekit#412) Fix ruby version not found. (devicekit#414) Version bump. (v5.2.4) Enable MERGEABLE_LIBRARY. (devicekit#407) Update cocoapods to v1.15.2 in Gemfile. Release 5.2.3 fix: Use cocoapod resource_bundles for PrivacyInfo (devicekit#397) Fix building for visionOS. (devicekit#390) Fix building SwiftUI previews on macOS. (devicekit#389) Release 5.2.1 (devicekit#385) Fix PrivacyInfo.xcprivacy not being detected on SPM. (devicekit#384) Update swift-tools-version in Package.swift to 5.3 to support Resource files. (devicekit#381) # Conflicts: # Source/Device.swift.gyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes visionOS compilation issues.
Cherry picked from #371
Closes #371
Fixes #370
Thanks @chrisvasselli!