new icon: p5js (original) #1465

yeyeto2788 · 2022-10-17T12:49:11Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #1421

Link to prove your SVG is correct and up-to-date.

lunatic-fox · 2022-10-22T23:49:33Z

Hello there!
@yeyeto2788 you're on the way, but there are few things that need to be fixed.

I think some linter is modifying the structure of devicon.json arrays. Perhaps, you can undo some steps until this file is in it's original structure.

Since this icon is a mono-color icon that contains the name of the technology, I think you can keep just the original version, rename it to original-wordmark and make an alias to plain-wordmark version.

And again the icon need to be in 128×128px size. If you need some help to do that on Inkscape, you can read the instructions bellow.

Instructions to resize to square

Select all. Ctrl+A
Group. Ctrl+G
Create a square with 128×128px of size.
Select all. Ctrl+A
Align the square and the icon to vertical center and horizontal center.
Resize the page to selection. Shift+Ctrl+R.
Delete the square.
Select the icon.
Ungroup. Shift+Ctrl+G
Save it and it's done!

About versions
https://github.com/devicons/devicon/wiki/SVG-Versions

About aliases
https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository

Wish for the best!

yeyeto2788 · 2022-10-24T07:43:29Z

Hey @lunatic-fox!

Thanks for pointing those instructions to me. I think I did everything to meet the requirements but if you still see something is missing or that I need to do something else just ping me.

Best.

lunatic-fox · 2022-10-24T18:34:23Z

Hello again @yeyeto2788! Great work! 🤩

Just few issues:

The icon needs to be united in one path, like what I commented about the plain and plain-wordmark icons of new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468
In devicon.json
- change the color #2088FF to #ED225D
- change in versions.font the plain to original-wordmark

yeyeto2788 · 2022-10-25T08:35:15Z

Hey there!

Changes applied, for this one it was a bit different as the Path > Union combination didn't work so I had to group them.

If something else is required, just let me know.

Best.

lunatic-fox · 2022-10-25T15:07:47Z

Hello again @yeyeto2788!
Please take a look at my last comment on Jira Align PR, the same instructions can be applied here to this icon. 👍🏼

yeyeto2788 · 2022-10-26T09:28:40Z

I'm so sorry for all the inconveniences. I think now it should be fine.

Best.

lunatic-fox · 2022-10-26T21:18:37Z

No worries! There is no inconvenience at all. 🙂
I didn't see before just two things: the altnames and tags properties are missing after name property.

Suggestion of altnames

"altnames": [
    "p5.js"
]

Suggestions of tags

"tags": [
    "javascript",
    "js",
    "library"
]

The icon is perfect now! 🎉

I remembered now that if you want you can also contact us on Discord server.

Snailedlt

Looks good, but some small changes are needed still before we can merge this :)

icons/p5js/p5js-original-wordmark.svg

devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

github-actions · 2022-10-31T15:36:56Z

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'p5js-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

github-actions · 2022-10-31T15:40:56Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt · 2022-10-31T16:02:04Z

Hi!

I'm the check-bot and we have some issues with your PR:
SVG Error in 'p5js-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.
Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot 😄

@yeyeto2788 Please scale the image so that the viewbox is 0 0 128 128. You can use iloveimg to do it

yeyeto2788 · 2022-10-31T18:27:55Z

Quick note on the iloveimg tool. It does not work that great in Firefox and it does changes almost everything from the SVGOMG which I thought it was more or less the recommended tool.

Snailedlt · 2022-10-31T19:26:14Z

Quick note on the iloveimg tool. It does not work that great in Firefox and it does changes almost everything from the SVGOMG which I thought it was more or less the recommended tool.

Didn't know that it was bad on firefox, how so?
I see it changed the formatting and added width and height attributes, so if you run it through SVGOMG after resizing it, it should be better :)

yeyeto2788 · 2022-10-31T19:36:12Z

Yeap it is weird, seems like the preview does not work as expected and also sometimes if you want to set height and width one or the other gets erased.

Should I do that for my PRs? I mean, SVGOMG now that it is resized? (🙏🏽 for no)

Snailedlt · 2022-10-31T19:53:00Z

@yeyeto2788 odd indeed. I think it should work fine with chrome... at least it's always worked for me.

Also yes, please optimize it using SVGOMG :)

yeyeto2788 · 2022-11-02T12:17:26Z

@yeyeto2788 odd indeed. I think it should work fine with chrome... at least it's always worked for me.

Also yes, please optimize it using SVGOMG :)

Passed again through SVGOMG hoping it does not screwed the changes from iloveimg.

Best.

github-actions · 2022-11-03T00:04:38Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

LGTM! ✔️
Well done, and thank you for your contribution! 🚀

devicon.json

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

lunatic-fox

Approved! ✔
Great contribution! 🚀

lunatic-fox

Merge conflicts resolved!

lunatic-fox · 2022-11-09T17:57:45Z

Entry moved to its alphabetical order in devicon.json

* Add icon for p5js * Fix minor issues on the commit. * Fix color for the icon and unite paths * Fix paths and ungroup objects. * Add altnames and tags to icon * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Rename icon * resize icon * Pass icons through SVGOMG * Update devicon.json Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> * Move entry to its alphabetical order Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

Add icon for p5js

daec925

Snailedlt self-requested a review October 19, 2022 13:22

Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 19, 2022

Snailedlt self-assigned this Oct 19, 2022

Fix minor issues on the commit.

5139031

Fix color for the icon and unite paths

a5982fa

Fix paths and ungroup objects.

a2b47dc

Add altnames and tags to icon

6813a16

Snailedlt requested changes Oct 29, 2022

View reviewed changes

icons/p5js/p5js-original-wordmark.svg Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

Snailedlt changed the title ~~new icon: p5js (original,plain)~~ new icon: p5js (original) Oct 29, 2022

This was referenced Oct 29, 2022

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

Merged

[OTHER] Extending wiki with tutorials for each recommended tool #1306

Open

yeyeto2788 and others added 3 commits October 31, 2022 07:33

Update devicon.json

bac8e64

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Rename icon

b1482cc

Merge branch 'p5js' of https://github.com/yeyeto2788/devicon into p5js

3811d3a

Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 31, 2022

resize icon

fc80ecc

Pass icons through SVGOMG

0542708

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 3, 2022

Snailedlt previously approved these changes Nov 3, 2022

View reviewed changes

Snailedlt removed their assignment Nov 3, 2022

lunatic-fox requested changes Nov 8, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Update devicon.json

5cd1af8

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

yeyeto2788 dismissed Snailedlt’s stale review via 5cd1af8 November 9, 2022 08:29

Snailedlt requested a review from lunatic-fox November 9, 2022 08:40

lunatic-fox previously approved these changes Nov 9, 2022

View reviewed changes

Merge branch 'develop' into p5js

aabeb3a

lunatic-fox dismissed their stale review via aabeb3a November 9, 2022 17:38

lunatic-fox previously approved these changes Nov 9, 2022

View reviewed changes

lunatic-fox requested a review from Snailedlt November 9, 2022 17:41

Move entry to its alphabetical order

4b0cba4

lunatic-fox dismissed their stale review via 4b0cba4 November 9, 2022 17:55

Snailedlt approved these changes Nov 10, 2022

View reviewed changes

Snailedlt requested a review from lunatic-fox November 10, 2022 15:38

lunatic-fox approved these changes Nov 11, 2022

View reviewed changes

Snailedlt merged commit 6c377e7 into devicons:develop Nov 11, 2022

yeyeto2788 deleted the p5js branch March 7, 2023 09:03

lunatic-fox mentioned this pull request Jun 11, 2023

new icon: framermotion (original, original-wordmark) #1788

Closed

6 tasks

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Snailedlt mentioned this pull request Jun 17, 2024

update icon: appwrite (original, original-wordmark, plain, plain-wordmark) #2196

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: p5js (original) #1465

new icon: p5js (original) #1465

yeyeto2788 commented Oct 17, 2022 •

edited by Snailedlt

Loading

lunatic-fox commented Oct 22, 2022 •

edited

Loading

yeyeto2788 commented Oct 24, 2022

lunatic-fox commented Oct 24, 2022

yeyeto2788 commented Oct 25, 2022

lunatic-fox commented Oct 25, 2022

yeyeto2788 commented Oct 26, 2022

lunatic-fox commented Oct 26, 2022

Snailedlt left a comment

github-actions bot commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

Snailedlt commented Oct 31, 2022

yeyeto2788 commented Oct 31, 2022

Snailedlt commented Oct 31, 2022

yeyeto2788 commented Oct 31, 2022

Snailedlt commented Oct 31, 2022 •

edited

Loading

yeyeto2788 commented Nov 2, 2022

github-actions bot commented Nov 3, 2022

Snailedlt left a comment

lunatic-fox left a comment

lunatic-fox left a comment

lunatic-fox commented Nov 9, 2022

new icon: p5js (original) #1465

new icon: p5js (original) #1465

Conversation

yeyeto2788 commented Oct 17, 2022 • edited by Snailedlt Loading

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

lunatic-fox commented Oct 22, 2022 • edited Loading

yeyeto2788 commented Oct 24, 2022

lunatic-fox commented Oct 24, 2022

yeyeto2788 commented Oct 25, 2022

lunatic-fox commented Oct 25, 2022

yeyeto2788 commented Oct 26, 2022

lunatic-fox commented Oct 26, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

Snailedlt commented Oct 31, 2022

yeyeto2788 commented Oct 31, 2022

Snailedlt commented Oct 31, 2022

yeyeto2788 commented Oct 31, 2022

Snailedlt commented Oct 31, 2022 • edited Loading

yeyeto2788 commented Nov 2, 2022

github-actions bot commented Nov 3, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

lunatic-fox left a comment

Choose a reason for hiding this comment

lunatic-fox left a comment

Choose a reason for hiding this comment

lunatic-fox commented Nov 9, 2022

yeyeto2788 commented Oct 17, 2022 •

edited by Snailedlt

Loading

lunatic-fox commented Oct 22, 2022 •

edited

Loading

Snailedlt commented Oct 31, 2022 •

edited

Loading