-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: framermotion (original, original-wordmark) #1788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how aliases work, but I guess this should work.
devicon.json
Outdated
"aliases": [ | ||
{ | ||
"base": "original", | ||
"alias": "original-wordmark" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea behind aliases works like:
- By default an icon is an
original
version. - Here is a flowchart about the possible bases and aliases:
flowchart LR;
original --> original-wordmark --> plain-wordmark
original-wordmark --> line-wordmark
original --> plain
original --> line
- Remember that the
base
is always an existent icon. - In this case we have
original
andoriginal-wordmark
, both working as plain icons, solid colors and one path. Therefore, we can from thebase: original
make analias: plain
, same goes tobase: original-wordmark
toalias: plain-wordmark
. - Here is an example of complex aliases: new icon: p5js (original) #1465
"aliases": [ | |
{ | |
"base": "original", | |
"alias": "original-wordmark" | |
} | |
] | |
"aliases": [ | |
{ | |
"base": "original", | |
"alias": "plain" | |
}, | |
{ | |
"base": "original-wordmark", | |
"alias": "plain-wordmark" | |
} | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice chart! 🚀 We should probably save that in the Wiki.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you soo much for explaining. ♥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess now everything looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the merge conflicts here. If you need any help, you can ask for help here or on our Discord server. You can also check the GitHub Docs to make the process easier. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1643
Link to prove your SVG is correct and up-to-date.
https://www.framer.com/