Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: framermotion (original, original-wordmark) #1788

Closed
wants to merge 6 commits into from
Closed

new icon: framermotion (original, original-wordmark) #1788

wants to merge 6 commits into from

Conversation

Gautam25Raj
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1643

Link to prove your SVG is correct and up-to-date.

https://www.framer.com/

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 11, 2023
devicon.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how aliases work, but I guess this should work.

@Gautam25Raj Gautam25Raj requested a review from Panquesito7 June 11, 2023 16:34
devicon.json Outdated
Comment on lines 3172 to 3177
"aliases": [
{
"base": "original",
"alias": "original-wordmark"
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea behind aliases works like:

  • By default an icon is an original version.
  • Here is a flowchart about the possible bases and aliases:
flowchart LR;
original --> original-wordmark --> plain-wordmark
original-wordmark --> line-wordmark
original --> plain
original --> line
Loading
  • Remember that the base is always an existent icon.
  • In this case we have original and original-wordmark, both working as plain icons, solid colors and one path. Therefore, we can from the base: original make an alias: plain, same goes to base: original-wordmark to alias: plain-wordmark.
  • Here is an example of complex aliases: new icon: p5js (original) #1465
Suggested change
"aliases": [
{
"base": "original",
"alias": "original-wordmark"
}
]
"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice chart! 🚀 We should probably save that in the Wiki.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you soo much for explaining. ♥

Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess now everything looks fine.

@Gautam25Raj Gautam25Raj requested a review from lunatic-fox June 15, 2023 14:12
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts here. If you need any help, you can ask for help here or on our Discord server. You can also check the GitHub Docs to make the process easier. 🙂

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Gautam25Raj Gautam25Raj closed this by deleting the head repository Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants