Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Frozen Datasource Delete #974

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Fix | Frozen Datasource Delete #974

merged 2 commits into from
Aug 21, 2023

Conversation

ThatcherK
Copy link
Contributor

@ThatcherK ThatcherK commented Aug 16, 2023 •
edited
Loading

This is fixing the issue raised here #970

@codecov-commenter
Copy link

Codecov Report

Merging #974 (c9aa20a) into develop (ca33092) will increase coverage by 10.55%.
The diff coverage is n/a.

❗ Current head c9aa20a differs from pull request most recent head a7dd9e7. Consider uploading reports for the commit a7dd9e7 to get more accurate results

@@             Coverage Diff              @@
##           develop     #974       +/-   ##
============================================
+ Coverage    46.33%   56.89%   +10.55%     
============================================
  Files          195      129       -66     
  Lines         7059     1965     -5094     
  Branches       491      520       +29     
============================================
- Hits          3271     1118     -2153     
+ Misses        3782      743     -3039     
- Partials         6      104       +98

see 95 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

APIYOJENNIFER
APIYOJENNIFER reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@APIYOJENNIFER APIYOJENNIFER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ThatcherK

@ThatcherK ThatcherK merged commit 7f9819f into develop Aug 21, 2023
@ThatcherK ThatcherK deleted the fix/frozen-datasource-delete branch August 21, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APIYOJENNIFER APIYOJENNIFER APIYOJENNIFER approved these changes

@wakibi wakibi Awaiting requested review from wakibi

@davidebukali davidebukali Awaiting requested review from davidebukali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThatcherK @codecov-commenter @APIYOJENNIFER