Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Frozen Datasource Delete #974

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Fix | Frozen Datasource Delete #974

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7dd9e7
Replace repo with schema field in delete_archive method
ThatcherK Aug 16, 2023
eeee22d
Delete frozen column maps before deleting frozen source
ThatcherK Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from django.db import transaction
from core.pypika_utils import QueryBuilder
from data.db_manager import fetch_data, analyse_query, run_query
from core.models import FrozenData, OperationStep, Source, Operation, FrozenData
from core.models import FrozenData, OperationStep, Source, Operation, FrozenData, SourceColumnMap
from pypika import Table, Query
from pypika import functions as pypika_fn
from core.pypika_fts_utils import TableQueryBuilder
Expand Down Expand Up @@ -50,11 +50,15 @@ def delete_archive(id):
frozen_data = FrozenData.objects.get(pk=id)
table_name = frozen_data.frozen_db_table
# Delete from sources table and operation steps
frozen_source = Source.objects.filter(repo='archives', active_mirror_name=table_name)
frozen_source = Source.objects.filter(schema='archives', active_mirror_name=table_name)
operation_step_qs = OperationStep.objects.filter(source_id__in=frozen_source)
frozen_column_maps = SourceColumnMap.objects.filter(source_id__in=frozen_source)
operation = Operation.objects.filter(pk__in=operation_step_qs.values_list('operation_id', flat=True))
operation.delete()
operation_step_qs.delete()
#Delete frozen column maps before deleting frozen source
for column_map in frozen_column_maps:
column_map.delete()
frozen_source.delete()
frozen_data.delete()
query_builder = TableQueryBuilder(table_name, "archives")
Expand Down