Update workload mappings for 2022 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
force-pushed
the
dev/2022
branch
2 times, most recently
from
2e1e41d to
1e50d94
Compare
We previously hardcoded the major VS version used to build the channel bootstrapper, but this was only necessary for Install scenarios, where we don't know already the channel/installation we're dealing with. So for update/modify, we pass down the selected instance (or default selected) major version, so we don't select the wrong major version inadvertently. In addition, for Install, we have a smarter heuristics now that will attempt to load the latest release bootstrapper major version from the official docs on CLI installs for VS, and defaulting to hardcoded "17" for now in the unlikely scenario where we can't reach the page for some reason. Fixes #123
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143