Skip to content

Commit

Permalink
fix(inline-resources): remove module ids from component metadata.
Browse files Browse the repository at this point in the history
> Removes the module ids of the component metadata.
> Since the templates and styles are now inlined, the module id has become unnecessary and
> can cause unexpected issues

This also fixes angular#974 in meanwhile.
  • Loading branch information
devversion committed Aug 10, 2016
1 parent 6e99d90 commit d9ae7ce
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions scripts/release/inline-resources.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ for (let arg of process.argv.slice(2)) {
readFile(filePath, 'utf-8')
.then(content => inlineTemplate(filePath, content))
.then(content => inlineStyle(filePath, content))
.then(content => removeModuleIds(content))
.then(content => writeFile(filePath, content))
.catch(err => {
console.error('An error occured: ', err);
Expand Down Expand Up @@ -96,3 +97,13 @@ function inlineStyle(filePath, content) {
+ ']';
});
}

/**
* Removes the module ids of the component metadata.
* Since the templates and styles are now inlined, the module id has become unnecessary and
* can cause unexpected issues.
*/
function removeModuleIds(content) {
// Match the line feeds as well, because we want to get rid of that line.
return content.replace(/^\W+moduleId:\W+module\.id,?[\n|\r]+/gm, '');
}

0 comments on commit d9ae7ce

Please sign in to comment.