Disaggregate consumer linting for full coverage #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfarrell07
force-pushed
the
disagg_cons_lint_test
branch
8 times, most recently
from
e367191 to
0e6def3
Compare
For better coverage, clearer maintenance, and more readable log output. This also removes the `make lint` target. Per discussion on submariner-io#739, it isn't used by devs and causes unclear maintenance that can result in gaps in test coverage. I looked at doing this by using per-project linter jobs and a custom GitHub Action for the logic that can be extracted. Because we can't use other GHAs in custom GHAs, we can't extract actions/checkout or would have to create custom git logic to extract the two checkout steps. Splitting each desired linter/project combo into a job results in lots of duplicated GHA boilerplate. It also wastes resources re-doing things like building the Shipyard image. Splitting each project into a parallel job and clearly separating the linting runs in the output using steps seems like the best solution overall. Also reorder markdownlint make target for consistent ABC ordering. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
force-pushed
the
disagg_cons_lint_test
branch
from
0e6def3 to
d9ff89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better coverage, clearer maintenance, and more readable log output.
This also removes the
make linttarget. Per discussion on submariner-io#739, itisn't used by devs and causes unclear maintenance that can result in
gaps in test coverage.
I looked at doing this by using per-project linter jobs and a custom
GitHub Action for the logic that can be extracted. Because we can't use
other GHAs in custom GHAs, we can't extract actions/checkout or would
have to create custom git logic to extract the two checkout steps.
Splitting each desired linter/project combo into a job results in lots
of duplicated GHA boilerplate. It also wastes resources re-doing things
like building the Shipyard image. Splitting each project into a parallel
job and clearly separating the linting runs in the output using steps
seems like the best solution overall.
Also reorder markdownlint make target for consistent ABC ordering.
Signed-off-by: Daniel Farrell dfarrell@redhat.com