Disaggregate consumer linting for full coverage

.github/workflows/consuming.yml

@@ -102,8 +102,47 @@ jobs:
       - name: Make sure ${{ matrix.project }} is using the built Shipyard image
         run: sed -i 's/shipyard-dapper-base:*.*/shipyard-dapper-base:dev/' ${{ matrix.project }}/Dockerfile.dapper
 
-      - name: Run all linters
-        run: make -C ${{ matrix.project }} lint
+      - name: Run gitlint
+        if: always()
+        run: make -C ${{ matrix.project }} gitlint
+
+      - name: Run golangci-lint
+        if: ${{ always() && matrix.project != 'submariner-charts' }}
+        run: make -C ${{ matrix.project }} golangci-lint
+
+      - name: Run markdownlint
+        if: always()
+        run: make -C ${{ matrix.project }} markdownlint
+
+      - name: Run packagedoc-lint
+        if: >-
+          ${{
+          always()
+          && matrix.project != 'cloud-prepare'
+          && matrix.project != 'coastguard'
+          && matrix.project != 'lighthouse'
+          && matrix.project != 'submariner-charts'
+          && matrix.project != 'submariner-operator'
+          }}
+        run: make -C ${{ matrix.project }} packagedoc-lint
+
+      - name: Run shellcheck
+        if: >-
+          ${{
+          always()
+          && matrix.project != 'admiral'
+          && matrix.project != 'cloud-prepare'
+          && matrix.project != 'coastguard'
+          && matrix.project != 'lighthouse'
+          && matrix.project != 'submariner'
+          && matrix.project != 'submariner-charts'
+          && matrix.project != 'submariner-operator'
+          }}
+        run: make -C ${{ matrix.project }} shellcheck
+
+      - name: Run yamllint
+        if: ${{ always() && matrix.project != 'submariner-charts' }}
+        run: make -C ${{ matrix.project }} yamllint
 
   unit-consuming:
     name: Unit Tests

Makefile.inc

@@ -148,7 +148,7 @@ deploy-latest:
 	$(MAKE) -o images -o preload-images deploy SUBCTL=~/.local/bin/subctl DEV_VERSION=latest CUTTING_EDGE=latest VERSION=latest DEPLOY_ARGS="$(DEPLOY_ARGS) --image_tag=subctl" using=$(using)
 
 ##### LINTING TARGETS #####
-.PHONY: gitlint golangci-lint lint markdownlint packagedoc-lint shellcheck yamllint
+.PHONY: gitlint golangci-lint markdownlint packagedoc-lint shellcheck yamllint
 
 # [gitlint] validates the commits are valid
 gitlint:
@@ -166,6 +166,14 @@ golangci-lint: $(VENDOR_MODULES)
 	golangci-lint linters
 	golangci-lint run --timeout 10m
 
+# [markdownlint] validates Markdown files in the project
+markdownlint:
+	md_ignored=($(patsubst %/modules.txt,%,$(VENDOR_MODULES))); \
+	if [ -r .mdignore ]; then \
+		md_ignored+=($$(< .mdignore)); \
+	fi; \
+	markdownlint -c .markdownlint.yml $${md_ignored[@]/#/-i } .
+
 # [packagedoc-lint] checks that the package docs don’t include the SPDX header
 packagedoc-lint:
 	result=0; \
@@ -177,16 +185,6 @@ packagedoc-lint:
 	done 2>/dev/null; \
 	exit $$result
 
-lint: gitlint golangci-lint markdownlint yamllint
-
-# [markdownlint] validates Markdown files in the project
-markdownlint:
-	md_ignored=($(patsubst %/modules.txt,%,$(VENDOR_MODULES))); \
-	if [ -r .mdignore ]; then \
-		md_ignored+=($$(< .mdignore)); \
-	fi; \
-	markdownlint -c .markdownlint.yml $${md_ignored[@]/#/-i } .
-
 # [shellcheck] validates your shell files
 shellcheck:
 	shellcheck -x -P $${SCRIPTS_DIR} $(SHELLCHECK_ARGS)