-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: authenticated calls in Candid UI #475
Feat: authenticated calls in Candid UI #475
Conversation
Looks good so far! Thanks for the contribution! |
Co-authored-by: Ryan Vandersmith <ryanvandersmith@gmail.com>
This is only tested manually in production. Let me know if I can improve Leaving this for now, until further review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
We don't need the target_test_canister
here. I can merge once it's removed.
Thank you! |
Here we go! |
Many thnx! Will this make it into dfx 0.15.2? I would be so proud 😄 |
Should be. I will make a PR to include this in dfx soon. |
Will have a look tomorrow i hope |
@Web3NL Does the merged version work with |
Yes, I think it supports both |
yes, i added a form to choose between ic0.app / icp0.io. Same for raw / non-raw |
Excuse me, I corrected my last response. Does this answer your question, or were you refering to the default identity provider, which now is always The |
From a responsive UX standpoint, the following three improvements would help a lot on smaller screen sizes:
@Web3NL, here is a partial solution in case you want to borrow any of this code: #480 |
I will have a look, thnx for tagging. And I think this feature deserves some documention on the portal on how a canister should serve the I will attend to that 🙂 |
I am asking because my I did: |
Ah, I see. Is this because If so, then there should also be an option to choose |
Deployed to the main net! Another possible improvement is to only show the |
Yes, or perhaps disable it and inform the user of the possibility with a link to how to set it up |
See #474 and demo link
Overview
Allow authenticated calls via Internet Identity (and possibly pem files)
Requirements
New deps:
auth-client
andidentity
packages fromagent-js
Modifications and additions to
tools/ui
Considered Solutions
Added II to Candid UI canister
Recommended Solution
Also recommend uploading pem files (with warning to developer about security)
Considerations
Should be easy to maintain, modifications of existing files are kept to a minimum
New deps version bumps
TODO
Remove
dfx.json
,canister_ids.json
andtarget_test_canister
from branch (left them for demo purpose)Browser compatibility check
Testing preferably with Docker and Selenium (for local II alternative origins testing over https)
UI enhancements
Gather feedback