Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up responsive layout for Candid UI auth panel #480

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Oct 17, 2023

This PR adjusts the style of the new auth UI. I also replaced the "infinity" logo with the monochromatic "astronaut" for consistency with Internet Identity login buttons in other DFINITY dapps.

Context: #475.

Desktop screen width:

image

Tablet screen width:

image

Mobile screen width:

image

@Web3NL
Copy link
Contributor

Web3NL commented Oct 18, 2023

May I ask, how do you guys locally develop this UI?
(I need to be able see the styling when in the iframe inside Motoko Playground)

@rvanasa only looking at the css, it looks like its (almost) done? Can I improve anything or should I go on to documenting this feature in portal?

@chenyan-dfinity
Copy link
Contributor

Two ways: 1) if you open the UI on a separate window and reduce the width of the browser window, the UI will change to its mini form; 2) To test it in the playground, update this line https://github.com/dfinity/motoko-playground/blob/main/src/config/actor.js#L38 to be the new Candid UI canister id.

@rvanasa
Copy link
Contributor Author

rvanasa commented Oct 18, 2023

only looking at the css, it looks like its (almost) done?

I'll take care of the responsive layout. :)

@rvanasa rvanasa changed the title Adjust style and layout for Candid UI authorization panel Set up responsive layout for Candid UI authorization panel Oct 18, 2023
@rvanasa rvanasa self-assigned this Oct 18, 2023
@rvanasa rvanasa marked this pull request as ready for review October 18, 2023 18:11
@chenyan-dfinity chenyan-dfinity merged commit 646f639 into master Oct 18, 2023
2 checks passed
@chenyan-dfinity chenyan-dfinity deleted the auth-ui-misc branch October 18, 2023 18:28
@rvanasa rvanasa changed the title Set up responsive layout for Candid UI authorization panel Set up responsive layout for Candid UI auth panel Oct 18, 2023
@Web3NL
Copy link
Contributor

Web3NL commented Oct 18, 2023

only looking at the css, it looks like its (almost) done?

I'll take care of the responsive layout. :)

Great!

I will make sure this is properly documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants