-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ckbtc): add optional timestamp to minter events #3157
Merged
lpahlavi
merged 6 commits into
master
from
lpahlavi/XC-147-add-timestamp-to-ckbtc-minter-events
Dec 19, 2024
Merged
chore(ckbtc): add optional timestamp to minter events #3157
lpahlavi
merged 6 commits into
master
from
lpahlavi/XC-147-add-timestamp-to-ckbtc-minter-events
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
added
CI_OVERRIDE_DIDC_CHECK
Skips the backwards compatibility didc check (explain in PR description why)
chore
CI_ALL_BAZEL_TARGETS
Runs all bazel targets and uploads them to S3
and removed
chore
labels
Dec 12, 2024
lpahlavi
force-pushed
the
lpahlavi/XC-147-add-timestamp-to-ckbtc-minter-events
branch
4 times, most recently
from
December 17, 2024 09:43
da59342
to
50dcfc1
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-147-add-timestamp-to-ckbtc-minter-events
branch
from
December 17, 2024 10:38
50dcfc1
to
c4eda9e
Compare
ninegua
reviewed
Dec 18, 2024
@ninegua Thanks a lot for the review! I have addressed your feedback and pushed the updated code. |
ninegua
approved these changes
Dec 19, 2024
gregorydemay
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lpahlavi for this PR, great job handling Candid/serde! Only minor comments a follow-up but otherwise LGTM!
lpahlavi
deleted the
lpahlavi/XC-147-add-timestamp-to-ckbtc-minter-events
branch
December 19, 2024 14:40
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
…ion (#3277) [(XC-238)](https://dfinity.atlassian.net/browse/XC-238) Add property tests for the ckBTC event serialization/deserialization logic where events (both legacy and new) are arbitrarily generated from all possible event types. See [this comment](#3157 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
CI_ALL_BAZEL_TARGETS
Runs all bazel targets and uploads them to S3
CI_OVERRIDE_DIDC_CHECK
Skips the backwards compatibility didc check (explain in PR description why)
@cross-chain-team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-238) ckBTC events, in contrast with ckETH events, do not have a timestamp. This makes it almost impossible to determine when something happened. To address this, this PR adds a timestamp to ckBTC minter events.
In order for this change to be backwards compatible, the timestamp is optional and events logged prior to the introduction of timestamps have a
None
value for this field. The deserialization of both legacy and new events is supported, however there is a breaking change to the Candid interface of theget_events
endpoint of the ckBTC minter (hence theCI_OVERRIDE_DIDC_CHECK
label) due to the new structure of theEvent
type (i.e. addition of a timestamp field). This is acceptable since it is a debug endpoint.