chore(ckbtc): property tests for event serialization and deserialization #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
force-pushed
the
lpahlavi/xc-238-proptest-for-encode-decode-events
branch
from
8dc3152 to
28c7082
Compare
lpahlavi
added
the
CI_ALL_BAZEL_TARGETS
lpahlavi
force-pushed
the
lpahlavi/xc-238-proptest-for-encode-decode-events
branch
from
28c7082 to
d57b093
Compare
lpahlavi
force-pushed
the
lpahlavi/xc-238-proptest-for-encode-decode-events
branch
from
d57b093 to
73a2e65
Compare
gregorydemay
approved these changes
Dec 20, 2024
| } | ||
|
|
||
| fn txid() -> impl Strategy<Value = Txid> { | ||
| pvec(any::<u8>(), 32).prop_map(|bytes| { |
There was a problem hiding this comment.
nit: Withuniform32(any::<u8>()) you directly obtain an array of the right size.
There was a problem hiding this comment.
Good point, thanks for the suggestion!
lpahlavi
deleted the
lpahlavi/xc-238-proptest-for-encode-decode-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-238) Add property tests for the ckBTC event serialization/deserialization logic where events (both legacy and new) are arbitrarily generated from all possible event types. See this comment.