Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend-canister): create_chunks #3898

Merged
merged 3 commits into from
Sep 3, 2024
Merged

feat(frontend-canister): create_chunks #3898

merged 3 commits into from
Sep 3, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Sep 3, 2024 •
edited by jira bot
Loading

Description

Adds create_chunks to the asset canister, which will be needed to upload multiple chunks in the same call in the next PR

Part 1 of SDK-1769

How Has This Been Tested?

Mostly covered by existing unit tests. Added a few cases where it was simple enough to use create_chunks as well

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 marked this pull request as ready for review September 3, 2024 15:25
@sesi200 sesi200 requested a review from a team as a code owner September 3, 2024 15:25
@sesi200 sesi200 merged commit 54897b5 into master Sep 3, 2024
298 of 299 checks passed
@sesi200 sesi200 deleted the SDK-1769-create-chunks branch September 3, 2024 15:56
@sesi200 sesi200 mentioned this pull request Oct 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesi200 @ericswanson-dfinity