-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload multiple asset chunks in the same call #3947
Conversation
Is
On master, it takes 3.475s. On this branch, it takes 3.833s. (Both using wasm from this branch) My simple chunk upload binary takes 2.158s. I expect icx-asset to be a bit slower because I didn't compute hash and didn't provide gzip files. But at least, it should be faster than master? |
Yes, it's 'just' a wrapper around Just tested myself. TLDR: it speeds things up significantly, but only with enough files. Measurements: Local with
After verifying with debug prints in the asset canister I am pretty certain this happens:
|
Description
The frontend canister sync now tries to batch multiple small content chunks into a single call using the
create_chunks
method added in #3898.This should lead to significantly faster upload times for frontends with many small files.
Also had to bump the
api_version
of the asset canister to build in backwards compatibility for the asset syncFixes SDK-1769
How Has This Been Tested?
Covered by existing e2e.
Manually tested repeatedly with many different average file sizes. Command to test:
Checklist: