Support SinceTs in iterators #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SinceTs can be used to read data above a particular timestamp. All data less with version less than the sinceTs will be ignored. SinceTs is always less than the readTs and when sinceTs is set, the data between sinceTs and readTs will be read. sinceTs <= data to be read <= readTs
NamanJain8
reviewed
Jan 25, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @manishrjain)
iterator.go, line 399 at r1 (raw file):
hash := y.Hash(opt.Prefix) for _, t := range filtered { if t.MaxVersion() < opt.SinceTs {
If the prefix is set to nil then we will end up picking all the tables.
iterator_test.go, line 149 at r1 (raw file):
iopt.SinceTs = sinceTs db.View(func(txn *Txn) error {
require.NoError()
NamanJain8
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim and @manishrjain)
ahsanbarkati
approved these changes
Jan 25, 2021
jarifibrahim
commented
Feb 4, 2021
| @@ -68,11 +69,6 @@ func (stream *Stream) Backup(w io.Writer, since uint64) (uint64, error) { | |||
| if !bytes.Equal(item.Key(), key) { | |||
| return list, nil | |||
| } | |||
| if item.Version() < since { | |||
There was a problem hiding this comment.
log an error if this happens.
iterator.go
Outdated
| allCopy := make([]*table.Table, len(all)) | ||
| copy(allCopy, all) | ||
| if opt.SinceTs > 0 { | ||
| tmp := allCopy[:0] |
There was a problem hiding this comment.
This filtering should be the last step in pickTables.
iterator.go
Outdated
| @@ -610,7 +623,8 @@ func (it *Iterator) parseItem() bool { | |||
|
|
|||
| // Skip any versions which are beyond the readTs. | |||
| version := y.ParseTs(key) | |||
| if version > it.readTs { | |||
| // Ignore everything that is above the readTs and below the sinceTs. | |||
| if version > it.readTs || version < it.opt.SinceTs { | |||
There was a problem hiding this comment.
Don't include the data at the sinceTs.
NamanJain8
added a commit
that referenced
this pull request
Jul 8, 2021
) With the introduction of SinceTs, a bug was introduced #1653 that skips the pending entries. The default value of SinceTs is zero. And for the transaction made at readTs 0, the pending entries have version set to 0. So they were also getting skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SinceTs can be used to read data above a particular timestamp. All data
less with version less than the sinceTs will be ignored.
SinceTs is always less than the readTs and when sinceTs is set, the
data between sinceTs and readTs will be read.
sinceTs < data to be read <= readTs
Fixes DGRAPH-2958
This change is