Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pendingWrites): don't skip the pending entries with version=0 #1721

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix(pendingWrites): don't skip the pending entries with version=0 #1721

merged 1 commit into from
Jul 8, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Jul 2, 2021 •
edited
Loading

Addresses https://discuss.dgraph.io/t/bug-iterator-inside-a-transaction/14794/2

With the introduction of SinceTs, a bug was introduced #1653 that skips the pending entries.
The default value of SinceTs is zero. And for the transaction made at readTs 0, the pending entries have version set to 0. So they were also getting skipped.

This change is Reviewable

@NamanJain8 NamanJain8 requested a review from manishrjain as a code owner July 2, 2021 17:39
@NamanJain8 NamanJain8 merged commit 3911787 into master Jul 8, 2021
@NamanJain8 NamanJain8 deleted the naman/pending-sincets branch July 8, 2021 08:14
NamanJain8 added a commit that referenced this pull request Jul 8, 2021
@NamanJain8
fix(pendingWrites): don't skip the pending entries with version=0 (#1721
6d11bcb 
)

With the introduction of SinceTs, a bug was introduced #1653 that skips the pending entries.
The default value of SinceTs is zero. And for the transaction made at readTs 0, the pending entries have version set to 0. So they were also getting skipped.

(cherry picked from commit 3911787)
@NamanJain8 NamanJain8 mentioned this pull request Jul 8, 2021
Merged
NamanJain8 added a commit that referenced this pull request Jul 8, 2021
@NamanJain8
fix(pendingWrites): don't skip the pending entries with version=0 (#1721
e1f9dce 
)

With the introduction of SinceTs, a bug was introduced #1653 that skips the pending entries.
The default value of SinceTs is zero. And for the transaction made at readTs 0, the pending entries have version set to 0. So they were also getting skipped.

(cherry picked from commit 3911787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamanJain8 @ahsanbarkati