fix(skiplist-handler): Iterate over skiplist and send updates to publisher #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ahsanbarkati and @jarifibrahim)
db.go, line 1048 at r1 (raw file):
Value: v.Value, ExpiresAt: v.ExpiresAt, version: v.Version,
No need for version.
db.go, line 1050 at r1 (raw file):
version: v.Version, UserMeta: v.UserMeta, meta: v.Meta,
Don't think it looks at the meta.
fredcarle
pushed a commit
to fredcarle/badger
that referenced
this pull request
Aug 1, 2023
…isher (dgraph-io#1697) When a skip-list is handed over to badger we should also send the entries in skiplist to the publisher so that all the subscribers get notified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skiplist is handled to badger, it is directly sent for writing to the LSM tree, and
the published doesn't send updates for the entries received in the skiplist. This PR
fixes it.
This change is