chore(ci): update dependency on Badger #8557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
added
the
slash-to-main
joshua-goldstein
changed the title
|
Reverting dgraph-io/badger#1696, dgraph-io/badger#1697, dgraph-io/badger#1698 in Badger on dgraph-main. |
joshua-goldstein
force-pushed
the
joshua/badger-test
branch
from
7631a78
to
56bcfb4
Compare
mangalaman93
requested changes
Jan 6, 2023
| @@ -93,6 +93,8 @@ github.com/cespare/xxhash v1.1.0 h1:a6HrQnmkObjyL+Gs60czilIUGqrzKutQD6XZog3p+ko= | |||
| github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc= | |||
| github.com/cespare/xxhash/v2 v2.1.1 h1:6MnRN8NT7+YBpUIWxHtefFZOKTAPgGjpQSxqLNn0+qY= | |||
| github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs= | |||
| github.com/cespare/xxhash/v2 v2.1.2 h1:YRXhKfTDauu4ajMg1TPgFO5jnlC2HCbmLXMcTG5cbYE= | |||
There was a problem hiding this comment.
can we cleanup the go.sum files. It seems to have older versions of dependency too
joshua-goldstein
force-pushed
the
joshua/badger-test
branch
from
1efbba3
to
9e48ed3
Compare
joshua-goldstein
force-pushed
the
joshua/badger-test
branch
from
9e48ed3
to
eca866a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR updates the dependency on Badger to the latest version of Badger used in the cloud (SHA 7677fcb of Badger) with two bug fixes (here and here), and the dependency on Ristretto is bumped up to v0.1.1. These fixes live on the
dgraph-mainbranch of Badger.To do
We see a failure in TestLargePlistSplit in posting/list_test.go. This was added as part of a cherry-pick #8297.