Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return mutated uids as part of the api.Response #102

Merged
merged 5 commits into from
Oct 11, 2019

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Oct 9, 2019

This would allow Alpha nodes to return a map of variable name => the uids belonging to the variable.


This change is Reviewable

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@pawanrawal you can click here to see the review status or cancel the code review job.

Copy link

@MichaelJCompton MichaelJCompton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I'll leave other comments to @mangalaman93 as he knows the upsert code.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @mangalaman93)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s avoid duplicated, similar looking fields.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @mangalaman93 and @pawanrawal)


protos/api.proto, line 66 at r1 (raw file):

	Latency latency = 3;
	map<string, Uids> mutated = 4;
	map<string, string> uids = 12;

Why not make uids field return <string, Uids> instead of having two which look similar.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me and adds the UID map


Reviewed with ❤️ by PullRequest

Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pawanrawal)

@pawanrawal pawanrawal merged commit 062f560 into master Oct 11, 2019
@mangalaman93 mangalaman93 deleted the pawanrawal/return-mutated-uids branch March 22, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants