Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop returning var values in upsert response #103

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Nov 6, 2019

We are returning response to the queries in an upsert. If user needs the values of variables used in upsert, it can look at the response of the query now, instead. Related to dgraph-io/dgraph#4210. Reverts the changes that were made in #102


This change is Reviewable

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mangalaman93, @MichaelJCompton, and @pawanrawal)


protos/api.proto, line 66 at r1 (raw file):

	Latency latency = 3;
	// Metrics contains all metrics related to the query.
	Metrics metrics = 5;

= 4, considering that we haven't done a release since introducing these fields.

We are returning response to the queries in an upsert.
If user needs the values of variables used in upsert,
it can look at the response of the query now, instead.
@mangalaman93 mangalaman93 merged commit 2007f08 into master Nov 21, 2019
@mangalaman93 mangalaman93 deleted the aman/multiple_mutation branch November 21, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants