Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick "Throw errors returned by retrieveValuesAndFacets" #4968

Merged
merged 1 commit into from
Mar 18, 2020

Commits on Mar 18, 2020

  1. Throw errors returned by retrieveValuesAndFacets (#4966)

    The error was being ignored and an empty response was being written because the
    condition in a case statement didn't exclude errors not equal to nil or ErrNoValue.
    
    This caused reads below the rollup Ts to succeed with an empty response when
    they should throw an error. The bug was triggered by running Jepsen tests with
    incremental rollups enabled.
    
    Fixes #4958
    martinmr committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    cb174f4 View commit details
    Browse the repository at this point in the history