Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v1.2: fix(ServeTask): Return error if server is not ready (#6019) #6022

Merged
merged 1 commit into from
Jul 16, 2020
Merged

release/v1.2: fix(ServeTask): Return error if server is not ready (#6019) #6022

merged 1 commit into from
Jul 16, 2020

Commits on Jul 16, 2020

  1. fix(ServeTask): Return error if server is not ready (#6019) 

    The grpcWorker.ServeTask function is called when a request is received
over the network (sent by a peer). This function doesn't consider the
health of the node before starting the processing of the request. If we
process a request before the node is ready, we might end up seeing
crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934

Fixes DGRAPH-1934

This bug was seen when running jepsen bank test with
kill-alpha and kill-zero nemesis.

(cherry picked from commit 9293c97)
    Ibrahim Jarif committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    2fd8b26 View commit details
    Browse the repository at this point in the history