Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHC 8.8 tracking ticket #1249

Closed
quasicomputational opened this issue Aug 26, 2019 · 14 comments · Fixed by #1324
Closed

GHC 8.8 tracking ticket #1249

quasicomputational opened this issue Aug 26, 2019 · 14 comments · Fixed by #1324
Labels
build Building, testing, installing, packaging, etc

Comments

@quasicomputational
Copy link
Collaborator

quasicomputational commented Aug 26, 2019 •
edited by sjakobi
Loading

Tracking ticket for GHC 8.8 issues, mostly dependencies. Updated 2020-05-30:

All packages are compatible with GHC-8.8, but CI doesn't include a GHC-8.8 job yet.
@jneira
Copy link
Collaborator

jneira commented Aug 26, 2019

I think we are going yo replace yaml with HsYaml soon so we 'll need to track it instead

@ocharles ocharles mentioned this issue Sep 18, 2019
Merged
@mergify mergify bot closed this as completed in #1324 Sep 19, 2019
@sjakobi
Copy link
Collaborator

sjakobi commented Sep 19, 2019

#1324 took care of prettyprinter and turtle, but the other dependencies still need updating.

@sjakobi sjakobi reopened this Sep 19, 2019
@sjakobi
Copy link
Collaborator

sjakobi commented Sep 27, 2019

I've updated the issue description. We're getting closer! :)

@quasicomputational
Copy link
Collaborator Author

Down to 4 blockers now.

@sjakobi
Copy link
Collaborator

sjakobi commented Sep 29, 2019

asn1-encoding got a compatible release.

Once we have a release that is compatible with GHC-8.8, we should make sure to re-add the Dhall packages to Stackage Nightly, since they were disabled in the recent switch to GHC-8.8.

@Gabriella439
Copy link
Collaborator

@sjakobi: I already opened a pull request to do so: commercialhaskell/stackage#4860

quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this issue Sep 30, 2019
@quasicomputational
Allow haskell-lsp 0.17.
bf47196 
This is related to dhall-lang#1249, since earlier versions don't support GHC
8.8.
@quasicomputational quasicomputational mentioned this issue Sep 30, 2019
Merged
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this issue Sep 30, 2019
@quasicomputational
Allow haskell-lsp 0.16.
d96bc14 
This is related to dhall-lang#1249, since earlier versions don't support GHC
8.8.
mergify bot pushed a commit that referenced this issue Oct 1, 2019
@quasicomputational @mergify
Allow haskell-lsp 0.16. (#1357)
24bb8b7 
This is related to #1249, since earlier versions don't support GHC
8.8.
@sjakobi sjakobi added the build Building, testing, installing, packaging, etc label Nov 12, 2019
@sjakobi sjakobi mentioned this issue Jan 5, 2020
Merged
@sjakobi
Copy link
Collaborator

sjakobi commented Jan 5, 2020

I hope that we can soon update CI to use 8.8 instead of 8.4 and 8.6. It might be worth waiting for 8.8.2 and an LTS series using that though.

Regarding dhall-nix: hnix looks kind of stuck and under-maintained these days. Maybe we should consider switching to the simpler language-nix package instead?! Also, does dhall-nix have any users at all?!

@Gabriella439
Copy link
Collaborator

@sjakobi: I'm pretty sure dhall-nix has some users, because I got a few complaints when the dhallToNix utility in Nixpkgs broke

language-nix looks very incomplete to me and I don't think we could use it

@sjakobi
Copy link
Collaborator

sjakobi commented Mar 3, 2020

hnix finally got a new release, but hnix-store-core is still unbuildable with 8.8: haskell-nix/hnix-store#56

@f-f f-f mentioned this issue Mar 16, 2020
Closed
3 tasks
@sjakobi sjakobi mentioned this issue Mar 31, 2020
Closed
@sjakobi sjakobi mentioned this issue May 4, 2020
Closed
@sjakobi sjakobi mentioned this issue May 21, 2020
Closed
6 tasks
@sjakobi
Copy link
Collaborator

sjakobi commented May 30, 2020

hnix finally got a GHC-8.8-compatible release in v0.8.0. Support for GHC 8.10 is currently WIP: haskell-nix/hnix#592

How about we update CI to use GHC 8.8 for the most recent GHC version?

@Gabriella439
Copy link
Collaborator

@sjakobi: We would need to upgrade Nixpkgs to a newer version, which is blocked by static-haskell-nix

@sjakobi
Copy link
Collaborator

sjakobi commented May 30, 2020

Thanks @Gabriel439. Are you referring to nh2/static-haskell-nix#73?

@Gabriella439
Copy link
Collaborator

@sjakobi: Yeah. That would minimally need to be fixed

@sjakobi
Copy link
Collaborator

sjakobi commented Jun 16, 2020

hnix-0.9 builds with GHC 8.10 too now, and dhall-nix too: #1862

We can discuss the CI upgrade in a new issue if necessary.

@sjakobi sjakobi closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Building, testing, installing, packaging, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dhall: Support GHC 8.8 dhall-lang/dhall-haskell
4 participants
@jneira @Gabriella439 @sjakobi @quasicomputational