Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhall-lsp-server: Allow haskell-lsp 0.17 #1622

Merged
merged 2 commits into from
Jan 5, 2020
Merged

dhall-lsp-server: Allow haskell-lsp 0.17 #1622

merged 2 commits into from
Jan 5, 2020

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Jan 5, 2020

dhall-lsp-server can be built with GHC 8.8 now.

Context: #1249

@sjakobi
Allow haskell-lsp-0.17
880fe82 
dhall-lsp-server can be built with GHC 8.8 now.
@sjakobi
Copy link
Collaborator Author

sjakobi commented Jan 5, 2020

I originally wanted to build with the latest version of haskell-lsp, 0.19.0.0, but ran into some changes around the Options type where I wasn't sure how to resolve them. @EggBaconAndSpam, maybe you could take a look at that if you find the time.

@mergify mergify bot merged commit b4939f5 into master Jan 5, 2020
@mergify mergify bot deleted the sjakobi/haskell-lsp-0.17 branch January 5, 2020 17:29
@EggBaconAndSpam EggBaconAndSpam mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjakobi @Gabriella439