Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig #13

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Add editorconfig #13

merged 1 commit into from
Feb 8, 2019

Conversation

ismay
Copy link
Member

@ismay ismay commented Feb 8, 2019

Adds an editorconfig file that matches the settings for prettier. This allows your editor to pick up on the whitespace (etc.) settings for a repo, so there won't be a mismatch for your indentation.

Don't know what you want the file in source to be called. I assumed editorconfig.config, but let me know if you prefer otherwise.

@varl
Copy link
Contributor

varl commented Feb 8, 2019

@ismay if you could rename it from editorconfig.config to editorconfig.config.rc that'd be great. 👍

image

@varl varl self-requested a review February 8, 2019 13:32
@varl varl merged commit 8b0c392 into master Feb 8, 2019
dhis2-bot pushed a commit that referenced this pull request Mar 25, 2019
# [2.0.0](v1.7.0...v2.0.0) (2019-03-25)

### Bug Fixes

* add 'target' to blacklisted folders ([#9](#9)) ([d6170b9](d6170b9))
* add apply/check command to js ([3da7d5c](3da7d5c))
* change to debug msg ([5be1ad2](5be1ad2))
* clean up js filter mechanism ([#21](#21)) ([ece8c53](ece8c53))
* do not put a scary error message when checking files ([#27](#27)) ([4cecb27](4cecb27))
* make the messages more meaningful ([#25](#25)) ([d2ae8af](d2ae8af))
* only the apply command was properly whitelisted ([#19](#19)) ([8a7556a](8a7556a))
* only whitelist js under js subcommand ([9dc010a](9dc010a))
* reset prettier and browserslists ([d1eab91](d1eab91))
* resolve cli-style path by using dirname ([3a61532](3a61532))
* update help text ([f820a66](f820a66))
* update pre-hook ([6988cf9](6988cf9))
* use reporter from helpers-engine ([ef79104](ef79104))
* use the new release script ([#31](#31)) ([2e2e454](2e2e454))
* use two-param version for pkg to identify assets ([284ce0b](284ce0b))

### Features

* add ability to pass in files to check and apply ([2e7fcdd](2e7fcdd))
* add editorconfig ([#13](#13)) ([8b0c392](8b0c392))
* add option to not stage formatted files ([00d5bc7](00d5bc7))
* allow check/apply commands for commit msgs ([aca257f](aca257f))
* convert to @dhis2/cli format ([d95179c](d95179c))
* set an exit code if js check fails ([#18](#18)) ([3833bea](3833bea))
* stop auto-install of prettier and other config files ([#29](#29)) ([8c030b1](8c030b1))

### BREAKING CHANGES

* removes the binaries for `code-style.js` and
`commit-style.js` and instead exposes a binary named `d2-style` which is
the subcommand which the `d2` cli will use.
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@varl varl deleted the add-editorconfig branch October 28, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants