Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove store #461

Closed
wants to merge 43 commits into from
Closed

feat: remove store #461

wants to merge 43 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2023

Removing the store and moving to individual data fetching hooks to prepare for the new endpoints.

Preparing for:

Todo

  • Update e2e tests
  • Update unit tests
  • Remove containers from pages
  • Remove store, directly use data fetching hooks instead (formfields & forms)
  • Abstract loading spinner
  • Add loading and error states where necessary
  • Fix prop types
    • Failed prop type: Invalid prop label of type object supplied to TransferOption, expected string. (fixed in newer ui version)
  • Check details for regressions
  • Make hooks more robust
  • Remove e2e test infrastructure imported from test(cypress): update to cypress 12 #484 before merging and update fixtures
  • Move refetch down from hook instead of reusing hook
    • ToggleJobSwitch
  • Fix jest tests
    • LabeledOptionsField
    • SkipTableTypesField
    • JobTableRow
    • JobTypeField
    • JobTable
    • RunJobAction
    • RunJobModal
    • JobEditFormContainer
    • DeleteJobAction
    • Actions

Follow up

  • Improve field loading and error states (ensure we're not throwing errors anywhere)
  • Improve test coverage
  • Remove deprecated query types
  • Add missing skipTableTypes translations
  • Improve parameter field handling (remove exceptions)
  • Lock exception cleanup does not retain parameters
  • Editing a job immediately after creation fails
  • Creating a continuous analytics table job results in a 500 error when loading the list route (from which the backend does not seem to recover)
  • Ensure that all hooks that modify returned data do not return the unmodified data in any condition

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 20, 2023

🚀 Deployed on https://pr-461--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 20, 2023 16:32 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 21, 2023 10:45 Inactive
@ghost ghost force-pushed the job-queues branch from 37a3a81 to 44c7f5a Compare February 21, 2023 10:46
@dhis2-bot dhis2-bot temporarily deployed to netlify February 21, 2023 10:49 Inactive
@ghost ghost force-pushed the job-queues branch from 44c7f5a to ed30b61 Compare February 21, 2023 14:15
@dhis2-bot dhis2-bot temporarily deployed to netlify February 21, 2023 14:18 Inactive
@ghost ghost force-pushed the job-queues branch from ed30b61 to 961e8e3 Compare March 1, 2023 13:44
@dhis2-bot dhis2-bot temporarily deployed to netlify March 1, 2023 14:01 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 6, 2023 11:40 Inactive
@ghost ghost force-pushed the job-queues branch 2 times, most recently from 248f7fe to 428b3c0 Compare March 6, 2023 11:50
@dhis2-bot dhis2-bot temporarily deployed to netlify March 6, 2023 11:52 Inactive
@ghost ghost force-pushed the job-queues branch from 428b3c0 to bf5bba9 Compare March 6, 2023 11:52
@dhis2-bot dhis2-bot temporarily deployed to netlify March 6, 2023 11:54 Inactive
@ghost ghost force-pushed the job-queues branch from bf5bba9 to b8d75aa Compare March 6, 2023 15:41
@dhis2-bot dhis2-bot temporarily deployed to netlify March 6, 2023 15:48 Inactive
@ghost ghost force-pushed the job-queues branch from 6bcad38 to 2b5f23f Compare March 6, 2023 15:58
@dhis2-bot dhis2-bot temporarily deployed to netlify March 6, 2023 16:04 Inactive
@ghost ghost force-pushed the job-queues branch from 2b5f23f to f997592 Compare March 7, 2023 13:24
@dhis2-bot dhis2-bot temporarily deployed to netlify March 7, 2023 13:26 Inactive
@ghost ghost force-pushed the job-queues branch from 2280887 to 8316312 Compare March 29, 2023 15:20
@ghost ghost changed the title feat: job queues feat: remove store Apr 5, 2023
@ghost ghost force-pushed the job-queues branch from 55c1f50 to de00c30 Compare April 12, 2023 12:53
@ghost ghost force-pushed the job-queues branch from 0e4fbd1 to 274e596 Compare April 12, 2023 14:16
@ghost ghost force-pushed the job-queues branch from 274e596 to 9e884c1 Compare April 12, 2023 14:51
@ghost ghost closed this Apr 26, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant