-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cypress): update to cypress 12 #484
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismay
force-pushed
the
update-cypress-master
branch
from
March 13, 2023 13:21
0e59252
to
edc5a3e
Compare
ismay
force-pushed
the
update-cypress-master
branch
from
March 13, 2023 13:37
edc5a3e
to
4458be2
Compare
This was referenced Mar 13, 2023
ismay
force-pushed
the
update-cypress-master
branch
5 times, most recently
from
March 21, 2023 14:52
e829c62
to
5b71372
Compare
ismay
force-pushed
the
update-cypress-master
branch
5 times, most recently
from
March 22, 2023 10:55
1618f1b
to
40724b8
Compare
ismay
force-pushed
the
update-cypress-master
branch
from
March 22, 2023 11:35
40724b8
to
f3f9ffe
Compare
ismay
force-pushed
the
update-cypress-master
branch
2 times, most recently
from
March 22, 2023 12:48
d83b0bb
to
fd8b877
Compare
🎉 This issue has been resolved in version 101.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI for this app is rather flaky. It was blocking the work I'm doing atm on the job queues. This PR fixes a couple things that during my tests have fixed the flakiness.
Env vars needed are:
CYPRESS_LOGIN_NAME
CYPRESS_LOGIN_PASSWORD
CYPRESS_LOGIN_SERVER
See
cypress.env.json.example
. CI is already configured with the necessary env vars.This approach is a little novel, but it works well and removes a lot of maintenance overhead for our cypress setup. Plus we're testing against an actual backend so there's also some added realism. See https://dhis2.slack.com/archives/C1XTS67ME/p1678701948371199 for more context.
Running time
Mocked backend:
Pre-seeded image (see here: #489):
Pre-seeded image with 4 extra runners:
Running time other methods
The test code for these runs isn't completely identical to the tests above, login for this suite is slightly slower (about 30s) due to logging in via the ui, so not a completely fair comparison. But these methods were slower overall anyway, so not that important.
Pre-seeded image, layer caching:
Dockerized backend: