Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: also bump deps in package distribution folder #105

Closed
Badisi opened this issue Apr 4, 2022 · 1 comment · Fixed by #106
Closed

feature request: also bump deps in package distribution folder #105

Badisi opened this issue Apr 4, 2022 · 1 comment · Fixed by #106
Labels

Comments

@Badisi
Copy link
Contributor

Badisi commented Apr 4, 2022

Consider the following:

root
└── dist
    ├── A
    └── B
└── projects
    ├── A
    └── B (depends on A)

When releasing both A and B, MSR will eventually find that A needs to be updated in B's deps.
It will even include a note for that in B's release notes: "Dependencies A: upgraded to x.x.x".
Which is a great feature!

But in my case both A and B where built to a dist folder prior to running MSR.
And the package.json that MSR will actually updates (in updateDeps.js#L311) is projects/B/package.json not dist/B/package.json which is the one that needs to be updated before publishing.

Would it be possible to also look for the pkgRoot option of @semantic-release/npm and made the changes in there too ?

Thanks!

@antongolub
Copy link
Collaborator

🎉 This issue has been resolved in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants