Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#105): also bump deps in package distribution folder #106

Merged
merged 1 commit into from
Apr 15, 2022
Merged

feat(#105): also bump deps in package distribution folder #106

merged 1 commit into from
Apr 15, 2022

Conversation

Badisi
Copy link
Contributor

@Badisi Badisi commented Apr 4, 2022

Closes #105

@Badisi
Copy link
Contributor Author

Badisi commented Apr 5, 2022

@antongolub, what about now ?

@Badisi
Copy link
Contributor Author

Badisi commented Apr 12, 2022

@antongolub, I refactored a bit to check against '.' as you requested and added some tests.

@antongolub
Copy link
Collaborator

Hey @Badisi,

I'll take a look in the next 24h.

lib/createInlinePluginCreator.js Outdated Show resolved Hide resolved
lib/createInlinePluginCreator.js Outdated Show resolved Hide resolved
@antongolub
Copy link
Collaborator

Everything seems fine. I'll merge this next morning to be able to rollback if needed.

@antongolub antongolub merged commit 1007040 into dhoulb:master Apr 15, 2022
@antongolub
Copy link
Collaborator

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@antongolub
Copy link
Collaborator

antongolub commented Apr 15, 2022

@Badisi,

Merged. Could you plz make a couple tweak ups?

  1. Introduce getRootPkgs(context) helper:
const getRootPkgs = (context, ...extra) => getPkgRootOptions(context).map((pkgRoot) => {
    const manifestPath = cleanPath(`${pkgRoot}/package.json`, context.cwd);
        return {
            path: manifestPath,
            manifest: getManifest(manifestPath),
            ...extra, // _depsChanged: pkg._depsChanged,
        };
    }),
  1. Rename getPkgRootOptions to getRootPkgs to define both helpers in one place.
  2. Add some notes about config.pkgRoot. Docs ref would be ok.

@Badisi Badisi deleted the patch-1 branch April 15, 2022 13:53
@Badisi
Copy link
Contributor Author

Badisi commented Apr 15, 2022

Done in PR #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: also bump deps in package distribution folder
2 participants