Three d render #114
Merged
Three d render #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid Datatype Context
PointLight represents a spherically symmetric light source ParallelLight represents parallel light rays covering the entire scene
|
Thinking about this more, the instances I defined on Spherical don't make much sense. Directions don't actually form an additive group, do they? |
|
Good point. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with code I'm about to push to diagrams-povray, the commits below allow rendering 3D diagrams in POVRay. I think the types would work for other backends which render, such as OpenGL.
I've only implemented a couple of the many sorts of CameraLens and light source which POVRay supports. I'm happy to add more if someone wants to make fisheye projections in Diagrams, or something.
I have not implemented any support for multiple cameras, as I talked about in email to diagrams-discuss.
All feedback is welcome.
I learned way more about GHC extensions today than I meant to....