Lights & Camera #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (r, g, b, _) = colorToSRGBA c | ||
|
|
||
| -- Use the FillColor attribute for the diffuse pigment of the object. Diagrams |
There was a problem hiding this comment.
Yeah, repurposing FillColor for this seems a bit silly to me. We should probably have a module Diagrams.ThreeD.Attributes with 3D-specific attributes. As you say though, we'll need to figure out what attributes make sense to make available for all 3D backends, and which attributes are povray specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces Renderable instances for types added in diagrams/diagrams-lib#114. It should not be merged until that is.
The code below uses the FillColor attribute to set the diffuse lighting color. Should we instead use a different attribute (SurfaceColor? DiffuseColor?), since the color in the rendered image is a combination of the surface color and the lighting?
I'm particularly interested in how much control people want over color / surface properties. The currently-possible images have no highlights, and there is no ambient light, so shadows are too dark. These should be easy to add later, but I'm not sure what properties are common, and which are idiosyncratic to POVRay.