-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image2 #174
Conversation
Here is how you would use the rasterific api.
and in cairo
|
Yes, I like this better too. |
Great, I'm inclined to merge and revisit images after fixpoint. On Wed, Apr 9, 2014 at 10:27 AM, Brent Yorgey notifications@github.comwrote:
|
uncheckedImageRef path w h = DImage (ImageRef path) w h mempty | ||
|
||
-- | Crate a diagram from raw raster data. | ||
fromRaster :: Renderable (DImage Embedded) b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged because it wasn't worth holding it up over more bikeshedding. But what do you think of changing the name of fromRaster
to rasterDia
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably and improvement.
I think this is simpler and better. You can ignore the comments in the pull request for image.
I kept
uncheckedImageRef
since we need to cache the width and height inloadImageExt
anyway so that backends can use them, but the user does not need to provide them explicitly when using the load functions.There is a companion rasterific branch, but the original cairo image branch works as is.