Doc/frenzy 2 #1247
Merged
Doc/frenzy 2 #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Makefile doc/contributors.rst doc/index.rst lib/kmer_hash.cc lib/kmer_hash.hh sandbox/collect-reads.py sandbox/correct-reads.py sandbox/estimate_optimal_hash.py sandbox/saturate-by-median.py sandbox/sweep-files.py sandbox/sweep-reads.py scripts/abundance-dist-single.py scripts/count-overlap.py scripts/do-partition.py scripts/filter-abund-single.py scripts/filter-abund.py scripts/find-knots.py scripts/interleave-reads.py scripts/load-into-countgraph.py scripts/make-initial-stoptags.py scripts/normalize-by-median.py scripts/split-paired-reads.py scripts/trim-low-abund.py setup.py tests/test_countgraph.py tests/test_scripts.py
Conflicts: doc/user/known-issues.rst
Conflicts: ChangeLog
| @@ -109,6 +109,7 @@ ready for review:: | |||
| http://en.wikipedia.org/wiki/Changelog#Format | |||
| - [ ] Was a spellchecker run on the source code and documentation after | |||
| changes were made? | |||
| - [ ] Does the script respect streaming IO? (Is it tested for streaming IO?) | |||
There was a problem hiding this comment.
Some pull requests don't have scripts, therefore 'the script' doesn't make sense.
| @@ -54,13 +54,13 @@ Pipelines | |||
| --------- | |||
|
|
|||
| All khmer scripts used by a published recommended analysis pipeline must be | |||
| included in scripts/ and meet the standards therein implied. | |||
| included in `scripts/` and meet the standards therein implied. | |||
There was a problem hiding this comment.
please also use double backticks in this file for code + pathname snippets
|
retest this please |
|
@mr-c Updated, ready for merge |
|
LGTM, thanks! |
This was referenced Sep 1, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-do of #1241